Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycard authentication device now reqires two users to activate events #6903

Merged
merged 8 commits into from
Aug 16, 2024

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Aug 8, 2024

About the pull request

it is writen down that two are reqired to activate red and so on but one can swipe twice fast and it work. this fixes it

Explain why it's good for the game

bugfix and has rp incentive to get second man to start redalert

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: two persons are needed to activate red, ert and emergency acces using cards
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Aug 8, 2024
@Ben10083
Copy link
Contributor

Ben10083 commented Aug 9, 2024

Want to point out that in event of unable to get 2 users, you can go to ARES and call for redalert/evac/distress-signal

code/modules/security_levels/keycard_authentication.dm Outdated Show resolved Hide resolved
code/modules/security_levels/keycard_authentication.dm Outdated Show resolved Hide resolved
@Zonespace27 Zonespace27 marked this pull request as draft August 12, 2024 02:24
@cuberound cuberound marked this pull request as ready for review August 16, 2024 19:32
@harryob harryob enabled auto-merge August 16, 2024 19:38
@harryob harryob added this pull request to the merge queue Aug 16, 2024
Merged via the queue into cmss13-devs:master with commit 88d3a63 Aug 16, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Aug 16, 2024
@Mister-moon1 Mister-moon1 mentioned this pull request Aug 21, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 24, 2024
Reverts #6903

On lowpop red alert and other actions requiring keycards can become
impossible due to lack of CIC staff, along with the fact of if you are
not a commander you cannot use ares to activate red alert and there will
likely not be a joe

# Changelog
:cl:
balance: Keycard swipers no longer require two unique keycards to
function.
fix: fixed the description text for the card swipe to reduce confusion
/:cl:

---------

Co-authored-by: Zonespace <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants