Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mines Boom 2: non-electric booglaoo #6906

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

LynxSolstice
Copy link
Contributor

@LynxSolstice LynxSolstice commented Aug 9, 2024

About the pull request

This PR is a revival of the original PR here: (#3615).
It adds antitank mines as an alternative/additive to claymores that target larger xenos. As well as a framework for making more bury-able mines.

Explain why it's good for the game

It offers a defensive/ambush utility to engineers that can be countered by xenos (dug up and acid'd) but that deters T3s.

Testing Photographs and Procedure

Screenshots & Videos

TESTING VIDEO

Changelog

🆑LynxSolstice, Totalepicness5, Thwomper, Sir.Crow, Silencer_pl
add: Adds anti tank mines and the framework for creating more bury-able mine types.
balance: Adds M19 Antitank mines to the engineer vendor, the req vendor with a scale of (round * 2), adds the M19 antitank mine.
spellcheck: ((title suggested by Silencer_pl)) Added descriptions for the Antitank Mine.
code: Original code by Totalepicness5, maintenance of the code by LynxSolstice.
refactor: Mine code flesh out more. (Refactor by Totalepicness5)
imageadd: Adds a sprite for an unburied and a buried Antitank Mine (Sprites by Thwomper), and a Mine box (Sprites by Sir.Crow)
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Code Improvement Make the code longer Refactor Make the code harder to read labels Aug 9, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 9, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@TheManWithNoHands
Copy link
Contributor

Badass, although i suggest renaming them. They dont seem to cause much AP damage at all and mainly stun after all.
The name shouldnt confuse people what the mines do.

@LynxSolstice
Copy link
Contributor Author

LynxSolstice commented Aug 10, 2024

Badass, although i suggest renaming them. They dont seem to cause much AP damage at all and mainly stun after all. The name shouldnt confuse people what the mines do.

Upped the damage in the next commit.

@LynxSolstice
Copy link
Contributor Author

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 11, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 22, 2024
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 27, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address ci fail

@harryob harryob marked this pull request as draft October 6, 2024 05:50
@LynxSolstice
Copy link
Contributor Author

address ci fail

Will work on addressing this.

@LynxSolstice LynxSolstice marked this pull request as ready for review October 13, 2024 04:28
@LynxSolstice
Copy link
Contributor Author

Passed CI

@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Oct 27, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Oct 27, 2024
@Blundir Blundir added Stale Exempt PR can't go stale Sprites Frozen Merge this and you will make the spritetainers angry. and removed Stale beg a maintainer to review your PR labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Feature Feature coder badge Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Refactor Make the code harder to read Sprites Approved confirmed no stray pixels Sprites Frozen Merge this and you will make the spritetainers angry. Sprites Remove the soul from the game. Stale Exempt PR can't go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants