-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPP MMG #6915
base: master
Are you sure you want to change the base?
UPP MMG #6915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gun and the ammo box is literally slight M2C tweak, find or make an actual sprite for both, we have special sprites for upp ammo boxes and special palette for upp guns.
Moving the UPP Map to a separate PR. |
Just a heads-up: the MMG values I used in PR #5945 were tested but not extensively. |
We'll likely get some chances to see it in action if the PR gets merged so a future balance PR can be done if its excessive. As it stands, it trades huge burst damage for sustained suppressing fire, plus the lack of being able to move the weapon, and the fact you'll only see these guns being placed by mappers and admins, not players, makes it easier to balance and less oppressive. |
Love it, thank you. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
/obj/structure/machinery/m56d_hmg/auto/t37/attackby(obj/item/O as obj, mob/user as mob) | ||
if(!ishuman(user)) | ||
return | ||
// RELOADING | ||
if(istype(O, /obj/item/ammo_magazine/m2c/t37)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we overriding this whole proc just to change this line? ideally we would change the parent proc in /obj/structure/machinery/m56d_hmg/auto like:
if(istype(O, /obj/item/ammo_magazine)
var/obj/item/ammo_magazine/magazine = O
if(magazine.default_ammo != ammo)
return
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
About the pull request
Adds in one feature from this now auto-closed PR: #5945
Adds the T37 MMG for the UPP, their alternative version to the USCM M2C. The T37 is a stationary weapon, meaning it can not be moved, it has a slower rate-of-fire but it can sustain firing for significantly longer before it will overheat.
Explain why it's good for the game
Useful features for mapping and events.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
add: Adds the T37 Medium Machine Gun to the UPP's arsenal. The T37 is an alternative variant of the M2C HMG, it is a stationary emplacement (that can not be redeployed) that has a slower rate of fire compared to the M2C, but it can fire for a far longer period of time before overheating.
/:cl: