Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sound for revive notification #6918

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

zzzmike
Copy link
Contributor

@zzzmike zzzmike commented Aug 11, 2024

About the pull request

The sound to notify you that you're being revived is no longer the ahelp sound, now it's a modification of the defib noise.

Explain why it's good for the game

More sound diversity (and it's an existing sound anyways just my own edit to it)

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
soundadd: revive notification has new sound (rather than the ahelp sound)
/:cl:

@github-actions github-actions bot added the Sound Blast 5 minutes of bass boosted music to our players label Aug 11, 2024
@harryob harryob added this pull request to the merge queue Aug 23, 2024
Merged via the queue into cmss13-devs:master with commit a25a054 Aug 23, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Aug 23, 2024
@zzzmike zzzmike deleted the patch-2 branch August 23, 2024 15:51
joookschad added a commit to joookschad/cmss13 that referenced this pull request Sep 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
Reverts #6918

The new sound notification is too loud and too high pitched to the point
where it's painful to listen to.
harry's permission

![image](https://github.com/user-attachments/assets/0644cafb-045f-45cf-9ed0-0fe610ece7f8)

:cl:
sounddel: removed the new revive notification
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sound Blast 5 minutes of bass boosted music to our players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants