-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datumizes Specialist Sets #6933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two things that I saw
Co-authored-by: kiVts <[email protected]>
Co-authored-by: kiVts <[email protected]>
Is it not currently reopening both? It removes both from the list when picking either, so the re-opening was just piggybacking off of it (old cryopod.dm line 345) Besides that this implementation looks great. Much cleaner and the incompatible_sets lists work even better and can be easily extended, nicely done! |
Looks like it was only done in when cryoed by pod, not when cryoed by admin |
About the pull request
Converts specialist sets into datums instead of list/string hell, improves a fair bit of surrounding code
Fixes a few things:
Explain why it's good for the game
Our old system sucked, this sucks significantly less
Testing Photographs and Procedure
Screenshots & Videos
Tested:
Changelog
🆑
fix: Fixed heavy sniper spec opening up the wrong specialist slot on admin cryo
/:cl: