Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistic #6945

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Conversation

blackcrystall
Copy link
Contributor

@blackcrystall blackcrystall commented Aug 13, 2024

About the pull request

Now you can see detailed statistic, kills/shots/hits/damage and more, kills/shots/hits/damage ff (admins can see it too, so don't to a lot of ff, grief ban 200%), and etc
Basicaly old statistic with full backend rework + new UI, also DB link... and potential easy way to adding new features to it
...
Take this screenshot, most actions is here you can see... just imagine more different values,
image
image
image
image

Changelog

🆑 BlackCrystalic
add: Added new statistic traking values
refactor: Fully redone statistic plus save in DB
ui: New TGUI for statistic
code: Made round end announce and etc more flexible
code: Mode names now is DEFINED
/:cl:

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 13, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added UI deletes nanoui/html Feature Feature coder badge labels Aug 13, 2024
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 13, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 14, 2024
@efzapa
Copy link
Contributor

efzapa commented Aug 14, 2024

we need friendly fire counters for guns, soul

@blackcrystall
Copy link
Contributor Author

we need friendly fire counters for guns, soul

It's already exist
: 3

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 14, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@realforest2001 realforest2001 added the Do Not Merge If you merge this PR, I will annihilate you label Aug 18, 2024
@realforest2001
Copy link
Member

This changes 130 files without a changelog or any details as to what it does beyond a vague titling of "Statistics 2.0" fix the changelog and detail what you're doing.

@realforest2001 realforest2001 marked this pull request as draft August 18, 2024 17:02
@blackcrystall
Copy link
Contributor Author

90% of 130 files changes is just renaming function and adding new statistic values...
basicaly I can only highlight changes to round end announces system and... that all, all other is directly linked to working statistic functionality

@github-actions github-actions bot added Refactor Make the code harder to read Code Improvement Make the code longer labels Aug 19, 2024
@blackcrystall
Copy link
Contributor Author

This better now? I addressed some issues with DESCRIPTION of PR

@blackcrystall blackcrystall marked this pull request as ready for review August 19, 2024 04:09
@blackcrystall
Copy link
Contributor Author

@realforest2001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Do Not Merge If you merge this PR, I will annihilate you Feature Feature coder badge Refactor Make the code harder to read UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants