Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Visual Effect #6946

Closed

Conversation

blackcrystall
Copy link
Contributor

@blackcrystall blackcrystall commented Aug 14, 2024

About the pull request

Port of some funny visuals from TGMC

Changelog

🆑 BlackCrystalic
add: additional visual effects for explosions & bullet hits
/:cl:

Deleted user added 2 commits August 14, 2024 06:41
…y attempts to figure out why ref and signal in game contain right refs, but when it calls... calls wrong one... fuck this debris
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 14, 2024
@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Aug 14, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 14, 2024
@deathrobotpunch
Copy link
Contributor

need picturesss

@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 14, 2024
@Blundir
Copy link
Contributor

Blundir commented Aug 14, 2024

Not all effects were ported or not all are working, also the circle of light looks very buggy and old, tgmc has fire effect for it, which as i can see, isn't ported.

Comparison of changes in your pr and tgmc explosion

dreamseeker_CBr4Gd5cls
dreamseeker_lRGJqotqHv

@Blundir
Copy link
Contributor

Blundir commented Aug 14, 2024

Wall bullet impacts are working fine, but mob ones are either not working or not ported

dreamseeker_SN04JZ4LMo

dreamseeker_QEiPtQRmhh

@blackcrystall
Copy link
Contributor Author

Effect on hit mob is not integrated,
Explosions: Probably I ported old port of it, or without some fix that I made later... I ported a port from other CMSS, so funny happens
:3
I'll check it later

@Blundir
Copy link
Contributor

Blundir commented Aug 14, 2024

The shock wave effect ends too soon and the light remains for too long, also i think explosion power doesn't change the explosion effect size, like on tgmc
dreamseeker_xYtbtZxyU8

@Blundir
Copy link
Contributor

Blundir commented Aug 14, 2024

The splatter and wall impact looks fine
dreamseeker_o4NjrEpwFe

dreamseeker_0ZWc3lsjZC

@Blundir
Copy link
Contributor

Blundir commented Aug 14, 2024

Also there is rocket launcher back blast and gun fire smoke effects, in case you want to port them too.

@Blundir
Copy link
Contributor

Blundir commented Aug 14, 2024

Also i think this was added by mistake
chrome_Yv4TN0YKyd

Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fill out your changelog correctly (you aren't mentioning everything you're adding) and add videos of the effects you're adding.

@Zonespace27 Zonespace27 marked this pull request as draft August 14, 2024 17:19
@blackcrystall
Copy link
Contributor Author

Nuh uh, I lazy to do it now, and not interested anymore in it, so... I'll close this pr and delete branch NOW, if anybody want to finish this, do it

@blackcrystall blackcrystall deleted the glass_flying_around branch August 27, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Merge Conflict PR can't be merged because it touched too much code Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants