Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops dead people from removing their cuffs #6976

Closed
wants to merge 5 commits into from

Conversation

zzzmike
Copy link
Contributor

@zzzmike zzzmike commented Aug 18, 2024

About the pull request

I think I just saw someone who was in the middle of removing their cuffs die, and then they finished removing their cuffs - so I'm adding a check to prevent that (also covers unbuckling when cuffed for good measure). I'm not sure if it was a niche race condition or what.

Explain why it's good for the game

Erm actually you shouldn't be able to remove your cuffs when you're dead 🤓

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: can't remove cuffs/unbuckle self while dead anymore
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Aug 18, 2024
@zzzmike zzzmike marked this pull request as draft August 18, 2024 20:59
@zzzmike zzzmike marked this pull request as ready for review August 18, 2024 21:07
@zzzmike
Copy link
Contributor Author

zzzmike commented Aug 19, 2024

kivts thinks im wrong about this and im too lazy to test atm so closing until i see it again or something

@zzzmike zzzmike closed this Aug 19, 2024
@efzapa
Copy link
Contributor

efzapa commented Aug 23, 2024

@zzzmike tested locally on commit 8981ad5d2daba32eea0567242c939735cdb1b41a

Testthing.1.mp4

doesnt look like anything really happened with both zips and cuffs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants