Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bursting+facehugger stats no longer count NPCs #6978

Merged
merged 11 commits into from
Aug 24, 2024

Conversation

zzzmike
Copy link
Contributor

@zzzmike zzzmike commented Aug 19, 2024

About the pull request

Bursting+facehugger stats no longer count NPCs

Explain why it's good for the game

Right now the stats seem to be half and half on whether they count NPCs or not, it should be one way or the other.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: bursting+facehugger stats disregard NPCs
/:cl:

@zzzmike zzzmike marked this pull request as draft August 19, 2024 00:18
@github-actions github-actions bot added the Fix Fix one bug, make ten more label Aug 19, 2024
@zzzmike zzzmike marked this pull request as ready for review August 19, 2024 00:22
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ishuman() || isyautja() is redundant - all yautja are human, so the first would pass, and the second would never be evaluated for yautja anyway

@harryob harryob marked this pull request as draft August 22, 2024 16:18
@zzzmike
Copy link
Contributor Author

zzzmike commented Aug 22, 2024

thanks harry - now that I think about it I think I need to also add something that stops it from counting burst stats in the first minute or so from spawning at roundstart, because it doesn't really make sense that the initial instant bursts from roundstart xenos should count in the stats either (if anyone knows the best way to write that please lemme know)

@zzzmike zzzmike requested a review from harryob August 22, 2024 22:22
@zzzmike
Copy link
Contributor Author

zzzmike commented Aug 22, 2024

thank you @Doubleumc for the help with the round time code on discord 👍

@zzzmike zzzmike marked this pull request as ready for review August 22, 2024 22:43
@harryob harryob marked this pull request as draft August 23, 2024 09:17
@zzzmike
Copy link
Contributor Author

zzzmike commented Aug 23, 2024

thanks again harry :)

@zzzmike zzzmike marked this pull request as ready for review August 23, 2024 16:37
@zzzmike zzzmike requested a review from harryob August 23, 2024 16:38
@harryob harryob added this pull request to the merge queue Aug 24, 2024
Merged via the queue into cmss13-devs:master with commit 87021fc Aug 24, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants