Smoke Minirockets for HvH CAS

[Tobias-Reaper-MD]

About the pull request

Added Smoke Minirockets ammo for CAS, for the UPP vs USCM game mode in dev. This was my first project so please excuse the odd coding choices if there are any.

Its been tested, and others agreed it was semi-reasonable but figures are easily changed if players disagree.

Explain why it's good for the game

CAS is a fun part of the standard game mode, and the main gameplay loop of a few roles includes firing CAS. However, for HvH some non-lethal CAS options were desired by the team. Hence, smoke.

Testing Photographs and Procedure

Screenshots & Videos

Changelog

🆑 Tobias_reaper
add: Added Smoke MiniRockets for CAS in HvH.
add: Heavy Beanbag round description.
/:cl:

[zzzmike]

I don't know if that's why it added missing changelog tag but worth a try anyways

[Tobias-Reaper-MD]

I don't know if that's why it added missing changelog tag but worth a try anyways

Thanks :) i have not forced it to emote, so im not totally sure how i would force it to not...

[zzzmike]

I don't know if that's why it added missing changelog tag but worth a try anyways

Thanls :) i have not forced it to emote, so im not totally sure how i would force it to not...

no prob :) try deleting the CL icon at the end (second one not first one) and putting /:cl: instead. Even if it converts it to an icon somehow, the slash should prompt the missing changelog tag to go away. if it helps, it's like an ending html tag where you go <img src>image.png</img> to end the image tag

[Tobias-Reaper-MD]

I don't know if that's why it added missing changelog tag but worth a try anyways

Thanls :) i have not forced it to emote, so im not totally sure how i would force it to not...

no prob :) try deleting the CL icon at the end (second one not first one) and putting /:cl: instead. Even if it converts it to an icon somehow, the slash should prompt the missing changelog tag to go away. if it helps, it's like an ending html tag where you go <img src>image.png</img> to end the image tag

That was the ticket, thanks for the help. Im rather new at this.

[zzzmike]

no prob, good luck on your first PR 👍

[Tobias-Reaper-MD]

no prob, good luck on your first PR 👍

i half expect it to be declined, but its all experience

[zzzmike]

usually they will work with you to help you fix issues unless they disagree with the change completely, and I doubt that a non-lethal smoke option would be objectionable.

if you're bored and you haven't done so yet, try downloading a copy of CM server code and running your changes on the local server to see how it goes. apparently maintainers need to approve something before linters can even error-check your code so that's something you could do while you wait

[Tobias-Reaper-MD]

usually they will work with you to help you fix issues unless they disagree with the change completely, and I doubt that a non-lethal smoke option would be objectionable.

if you're bored and you haven't done so yet, try downloading a copy of CM server code and running your changes on the local server to see how it goes. apparently maintainers need to approve something before linters can even error-check your code so that's something you could do while you wait

Iv already tested it local, works fine. Iv a minor CS background so i think the code is somewhat sound.

[zzzmike]

cool 👍 - i doubt it will get rejected

[Steelpoint]

This is a good addition. A future idea may be to add at least one non-lethal ammo type for each gun-type, such as rubber-bullets for the gatling gun.

It might be ideal to lock this ammo to the 'faction_clash' game mode if you feel up to the challenge, as it is otherwise going to be useless in the standard distress_call game mode, we'd not want people to spend their limited points on it.

It may also be ideal to lock-off all other ammo types during HvH, as we don't want people using the oppressive lethal ammo, but this might be harder to code.

[cuberound]

This is a good addition. A future idea may be to add at least one non-lethal ammo type for each gun-type, such as rubber-bullets for the gatling gun.

It might be ideal to lock this ammo to the 'faction_clash' game mode if you feel up to the challenge, as it is otherwise going to be useless in the standard distress_call game mode, we'd not want people to spend their limited points on it.

It may also be ideal to lock-off all other ammo types during HvH, as we don't want people using the oppressive lethal ammo, but this might be harder to code.

yes that is idealy planed, there aint much nonlethal for laser, also to adjust how flag NO_LETHAL_CAS behaves so that this ammo and guns show up with that flag

[zzzmike]

By the way @Tobias-Reaper-MD are you still working on this? If it's ready for a review then you do have to undraft this at some point or maintainers may never look at this - draft is basically the 'don't review this yet' status.

[deathrobotpunch]

uhhh how would you provide CAS in space, I think you need a dedicated Close Space Support

[cmss13-ci]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself