Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human vs human AA tower #7013

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

SerheyKr
Copy link
Contributor

@SerheyKr SerheyKr commented Aug 23, 2024

About the pull request

Splitting the work on HvH gamemode to more PRs for easier reviews

Explain why it's good for the game

Adding AA towers to protect some area from CAS attacks

Testing Photographs and Procedure

Screenshots & Videos Some codesprites

AA_USCM
AA_UPP
AA_OFF
AA_DESTR

Changelog

🆑 Sergeys
add: Added Anti Air tower to UPP and USCM factions
imageadd: AA tower image
/:cl:

@SerheyKr SerheyKr requested a review from fira as a code owner August 23, 2024 12:00
@github-actions github-actions bot added the Sprites Remove the soul from the game. label Aug 23, 2024
@SerheyKr SerheyKr marked this pull request as draft August 23, 2024 12:15
@github-actions github-actions bot added the Feature Feature coder badge label Aug 23, 2024
@SerheyKr SerheyKr marked this pull request as ready for review August 23, 2024 12:32
message += SPAN_INFO("It has [SPAN_HELPFUL("[health]/[health_max]")] health.")
return list(message)

/obj/structure/machinery/defenses/planetary_anti_air/attackby(obj/item/O as obj, mob/user as mob)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no one letter vars

return TURF_PROTECTION_NONE

/obj/structure/machinery/defenses/planetary_anti_air/power_on_action(mob/user)
var/turf/T = get_turf(src)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no one letter vars

set_light(luminosity_strength)
visible_message("[icon2html(src, viewers(src))] [SPAN_NOTICE("The [name] hums to life and emits several beeps.")]")

for(var/turf/A as anything in RANGE_TURFS(covered_range, loc))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no one letter vars

return
for(var/area/internal_area in shuttle_areas)
for(var/turf/internal_turf in internal_area)
for(var/mob/M in internal_turf)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no one letter vars

return
for(var/area/internal_area in shuttle_areas)
for(var/turf/internal_turf in internal_area)
for(var/mob/M in internal_turf)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no one letter vars

if(!do_after(user, hack_time * user.get_skill_duration_multiplier(SKILL_CONSTRUCTION), INTERRUPT_ALL|BEHAVIOR_IMMOBILE, BUSY_ICON_BUILD, src))
additional_shock++
if(prob(50))
var/mob/living/carbon/human/H = user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no one letter vars

disassemble_time = 150
health = 500
health_max = 500
var/luminosity_strength = 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var declarations after var overrides

var/covered_range = 40

var/linked_turfs_restricted = list()
var/linked_turfs_covered = list()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you declare a list then you cast it as list, e.g. var/list/this = list()

user.visible_message(SPAN_NOTICE("[user] disassembles [src]."), SPAN_NOTICE("You disassemble [src]."))

playsound(loc, 'sound/mecha/mechmove04.ogg', 30, 1)
var/turf/T = get_turf(src)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no one letter vars

var/obj/structure/machinery/defenses/planetary_anti_air/highest_aa = null
var/protection_level = TURF_PROTECTION_NONE

for (var/obj/structure/machinery/defenses/planetary_anti_air/planetary_aa in src.linked_aa)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (var/obj/structure/machinery/defenses/planetary_anti_air/planetary_aa in src.linked_aa)
for (var/obj/structure/machinery/defenses/planetary_anti_air/planetary_aa in linked_aa)

only need to do src.var in initialize proc, do that to every var that has src.var in this pr

@kiVts kiVts marked this pull request as draft August 27, 2024 05:22
@SerheyKr SerheyKr requested a review from kiVts August 27, 2024 10:55
@SerheyKr SerheyKr marked this pull request as ready for review August 27, 2024 11:16
@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Oct 27, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Remove the soul from the game. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants