-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LV-624 Corporate Dome Nightmare Insert Changes #7031
Open
BOBAMAx
wants to merge
12
commits into
cmss13-devs:master
Choose a base branch
from
BOBAMAx:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+221
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mapping
did you remember to save in tgm format?
Feature
Feature coder badge
labels
Aug 25, 2024
Nanu308
reviewed
Sep 1, 2024
Nanu308
reviewed
Sep 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mapping itself is fine, need to look through survs for the sec goons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
Feature coder badge
Mapping Approved
adds 500 new dict keys
Mapping
did you remember to save in tgm format?
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR adds three new goon survivor roles and adds them to the corporate dome nightmare insert:
Medic, Engineer, and Team Lead.
Also, I added the original goon survivor to the weyland_survivor faction along with all the new goon survivor roles, as it never had it for some reason. This meant that all the nightmare roles excluding the CL himself would set off the WY motion detector included in the insert. Now none of them do, with the added side effect of being on the PMC IFF network now, just like the regular goon ERT.
There is now a spawner for:
1 CL
1 TL
1 Medic
1 Engineer
and a bunch of regular goons.
I tried to keep the equipment and skills they start with on par with regular survivor roles minus the engineer, who got the ERT fuel satchel to make him more visually distinct from a regular goon because folded welding goggles are basically invisible compared to a medhud. I'm not too concerned about the NSG the leader has because it's the stripped version with no underbarrel flamethrower and half the maps have NSG spawns that nobody uses anyway because the gun kinda sucks.
The goon leader has similar skills to the ERT version which includes engineering skills.
Spawn priority is:
CL = Medic > TL > Engineer > Standard Goons.
Explain why it's good for the game
The same rationale for why the solaris PMC insert and the CLF crashed ship insert got engineers, medics, and team leads: survivor gameplay without medics or engineers sucks. Getting IB is now no longer a guaranteed death sentence and the plasteel the nightmare insert includes can now actually be used by someone other than a synthetic survivor. The team lead isn't as important but having a distinct shotcaller is good for organization like with FORECON and the CLF insert. Also, he looks cool.
Testing Photographs and Procedure
Tested by forcing the insert and manually spawning myself as all the new and edited roles with the player panel equipment menu. This is my first PR though so I could have messed something up.
Changelog
🆑 BOBAMA
add: Added Goon Survivor Engineers, Medics, and Team Leads and put them in the LV-624 Corporate Dome Nightmare Insert.
maptweak: slightly adjusted LV-624 Corporate Dome Nightmare Insert Survivor Spawns.
/:cl: