Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes containers more destructible #7032

Merged
merged 11 commits into from
Oct 28, 2024

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Aug 25, 2024

About the pull request

makes containers destructible by bullets, xeno slashing and adds proper behavior for explosion act

Explain why it's good for the game

having containers that can be only removed with acid or instantly deleted by slightest destruction while invournuable to any other form of damage is rather silly, especily as it resoults in marines having to use explosives inside of FOB to get rid of containers in their way.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: containers are destructible with bullets and xeno slashing
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Aug 25, 2024
@Git-Nivrak
Copy link
Contributor

mfw I arrive to 'containers' on LV and find nothing but a wasteland...

code/game/objects/structures/cargo_container.dm Outdated Show resolved Hide resolved
code/game/objects/structures/cargo_container.dm Outdated Show resolved Hide resolved
@Nanu308 Nanu308 added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Oct 13, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

balance fine map items we can spam

@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Oct 27, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Oct 27, 2024
@harryob harryob added this pull request to the merge queue Oct 28, 2024
Merged via the queue into cmss13-devs:master with commit bb0ca97 Oct 28, 2024
27 checks passed
cmss13-ci bot added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants