Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops Crawling whilst being grabbed. Adds a notice as well. #7039

Conversation

MistChristmas
Copy link
Contributor

@MistChristmas MistChristmas commented Aug 25, 2024

About the pull request

Addresses #6842
Stops crawling if you're being aggressive grabbed or grabbed by a xeno.

Meaning people being carried or aggressively grabbed can't crawl and look silly whilst you're carrying them or be mildly annoying whilst you're not.

This previously also let you crawl if a xeno grabbed you. Which seems silly but actually useful because they'd just shove you down and that would stop you moving anyway.

Explain why it's good for the game

Fixes an oversight on crawling. Doesn't let you crawl away whilst a xeno has you. Doesn't let you crawl whilst you're being fireman carried.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 MistChristmas
fix: Stops crawling whilst grabbed
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Aug 25, 2024
code/modules/mob/mob_movement.dm Outdated Show resolved Hide resolved
@kiVts kiVts marked this pull request as draft August 26, 2024 00:20
@MistChristmas
Copy link
Contributor Author

Changed it from any grab to aggressive or above grab, or a xeno grab.

Copy link
Contributor

@kiVts kiVts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case

code/modules/mob/mob_movement.dm Outdated Show resolved Hide resolved
@MistChristmas MistChristmas marked this pull request as ready for review August 26, 2024 01:35
@zzzmike
Copy link
Contributor

zzzmike commented Aug 26, 2024

the code as it stands now doesn't fix anything on the human side... you already can't crawl while in an aggressive grab, it prompts you to do a moving_resist as per code here
image

(it's not the entire moving_resist code but it's very findable)

@zzzmike
Copy link
Contributor

zzzmike commented Aug 26, 2024

the bug report that this is based off of is not a bug from my testing, the person being carried and trying to move in any capacity including crawl does the moving_resist as normal, they only move if the resist rng passes, which is the right behavior, because you're resisting out of the grab, you're no longer grabbed if the rng passes (you're on the ground), and at that point you should be allowed to move however you want to

image

@MistChristmas MistChristmas marked this pull request as draft August 26, 2024 14:54
@MistChristmas
Copy link
Contributor Author

the bug report that this is based off of is not a bug from my testing, the person being carried and trying to move in any capacity including crawl does the moving_resist as normal, they only move if the resist rng passes, which is the right behavior, because you're resisting out of the grab, you're no longer grabbed if the rng passes (you're on the ground), and at that point you should be allowed to move however you want to

Weird I remember making the report because specifically one person was crawling whilst being in my carry without breaking my grip. Causing it to look like they're lagging behind whilst moving and being carried. Maybe there's more to it to pull it off. But yeah my testing concurs that you're right and I'm dumb.

@MistChristmas
Copy link
Contributor Author

Binning this for now unless I can recreate the initial issue that triggered this. Probably not.

@zzzmike
Copy link
Contributor

zzzmike commented Aug 26, 2024

the bug report that this is based off of is not a bug from my testing, the person being carried and trying to move in any capacity including crawl does the moving_resist as normal, they only move if the resist rng passes, which is the right behavior, because you're resisting out of the grab, you're no longer grabbed if the rng passes (you're on the ground), and at that point you should be allowed to move however you want to

Weird I remember making the report because specifically one person was crawling whilst being in my carry without breaking my grip. Causing it to look like they're lagging behind whilst moving and being carried. Maybe there's more to it to pull it off. But yeah my testing concurs that you're right and I'm dumb.

No worries, maybe something in the code changed since the report. I just tested this because I fireman carry a lot and I was curious.

github-merge-queue bot pushed a commit that referenced this pull request Oct 28, 2024
# About the pull request
see title, code is copied from  #7039 
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game

players (mostly synths and predators) were able to easily escape xeno
bodyblocks by just crawling away, and there was nothing that xeno
players could do to counter it. Now preds/synths can still try to crawl
to escape a bodyblock (over attempting to crit a xeno blocking them), at
the cost of it failing if a xeno grabs them.
# Testing Photographs and Procedure
Tested it, works.

# Changelog
:cl: MistChristmas, Private-Tristan
balance: You can no longer crawl while being grabbed by a xenomorph.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants