Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Marine HUD Icons, HUD Icon standardization #7054

Closed
wants to merge 4 commits into from

Conversation

Kitsunemitsu
Copy link
Contributor

@Kitsunemitsu Kitsunemitsu commented Aug 28, 2024

About the pull request

This PR does a few things;

  1. It standardizes the Tassels below the HUD Icons. Bronze for Non-Department Head Officers (PO, CE is below ASO now, Doc, SO, IO, Researcher, Doctor), and Gold for Department heads (CMO, CMP, ASO, XO.)
    QM now gets the same bronze border of the SEA, for being a senior NCO, and now has a bronze tassel.
    I believe that's how it was originally intended to be, and I'm just standardizing it.

  2. It gives a new icon to the ASO, something different than a silver star, it's now a gold triangle, made of 4 shades, one for each department (Flight, Requisitions, Engineering and Intelligence.

3. It brings CM-SS13 in line with the geneva conventions; the Doctor, CMO and researcher icon have all been changed to remove all Red Crosses. They are now officers, so I've given them the officer color scheme and bronze tassel. You can see it below.
No Longer true. Medical Icons are unchanged, with a recommendation put below.

  1. IO icon has been moved back with the other marine huds.

Explain why it's good for the game

Some standardization among Marine Hud icons, adds back in the gold tassels, removes a pair of geneva convention violations, and adds in a new ASO icon to remove that old placeholder one

Testing Photographs and Procedure

Screenshots & Videos New ASO Icon: ![image](https://github.com/user-attachments/assets/7f231a7f-8b1b-4304-a9d5-bbeee3daa0d8)

Changelog

🆑
imageadd: added a new Marine hud icon for some officers.
/:cl:

@github-actions github-actions bot added the Sprites Remove the soul from the game. label Aug 28, 2024
@Kitsunemitsu
Copy link
Contributor Author

Kitsunemitsu commented Aug 28, 2024

image

Here's some old ideas I had for Squad Leader without ASL status and the gunship pilot, not in this PR but maybe in a future one

Copy link
Contributor

@ItsVyzo ItsVyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly revert the color of the medical doctors back to red.

It does NOT violate the Geneva Conventions.

https://www.icrc.org/en/document/video-games-get-real

https://discord.com/channels/150315577943130112/746325423289401395/928276150948601866

@Kitsunemitsu
Copy link
Contributor Author

Kitsunemitsu commented Aug 28, 2024

Reverted back for now, Here's an idea to standardize it with other officer
This is the current set:

image

This is a set I recommend to standardize it with other officer roles, CMO with gold to match the CMP, XO, CE, etc and Doctors with the bronze tassel like other non-department head officers.
image

@ItsVyzo
Copy link
Contributor

ItsVyzo commented Aug 28, 2024

Reverted back for now, Here's an idea to standardize it with other officer This is the current set:

image

This is a set I recommend to standardize it with other officer roles, CMO with gold to match the CMP, XO, CE, etc and Doctors with the bronze tassel like other non-department head officers. image

That should be fine. Not sure how to feel about the gold. That aside, you have duplicate icons which is why Linters is going off.

@Kitsunemitsu
Copy link
Contributor Author

I might have accidentally pushed again, GH has been a bit fuckey with CM code.
I'll review it in the morning

@Blundir
Copy link
Contributor

Blundir commented Aug 28, 2024

Thank you for your pr, but we don't need to make current icons for non WO modes to look more like WO ones, also i don't think that these listed changes are needed.

@Blundir Blundir closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants