Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds text to speech #7095

Closed

Conversation

Watermelon914
Copy link
Contributor

@Watermelon914 Watermelon914 commented Sep 3, 2024

About the pull request

As the title says. Adds text to speech. Will be testmerged for a bit to gauge player feedback and see what people think.

TTS can be disabled individually if you don't like it via your preferences menu within the Preferences -> Settings section. There is an option to switch to blips only (don't starve voices) and an option to completely turn it off for yourself. Additionally, TTS volume can be configured alongside ambience and sfx volume.

You can change your voice and pitch via the preferences menu individually for your human character, synth character, and xenomorph character.

Yautja do not have TTS at this time, pending proper filter implementation to make them sound yautja-like.

Explain why it's good for the game

Can significantly help with communication. For now, it's unavailable over radio due to complications but it'll be available for hivemind xenomorphs, limited to the queen and leaders only for now.

This can be extended to radio messages in some capacity sometime later if people like it enough to keep it but this is mostly just testing the waters.

Testing Photographs and Procedure

I've tested it locally with a local key and it seems to work all fine.

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Adds text to speech for most characters. Modify your voice within your preference menu. Can be turned off via preferences menu or by setting TTS volume to 0.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Sep 3, 2024
@Watermelon914 Watermelon914 added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Sep 3, 2024
cm13-github added a commit that referenced this pull request Sep 3, 2024
cm13-github added a commit that referenced this pull request Sep 3, 2024
cm13-github added a commit that referenced this pull request Sep 3, 2024
@Kitsunemitsu
Copy link
Contributor

Small bug, multicast says everything 4 times.

@TheGamerdk
Copy link
Contributor

Working Joes say their voice-lines twice.

Also, what's the performance impact of this?

cm13-github added a commit that referenced this pull request Sep 3, 2024
@Watermelon914
Copy link
Contributor Author

Working Joes say their voice-lines twice.

Also, what's the performance impact of this?

Performance impact should generally be minimal, it's basically just playing sounds around people, though they are dynamically generated sounds.

Some things need to be examined tho, and you might experience clientside lag if you have a weak connection since it basically sends you over the sound file to play.

@Watermelon914
Copy link
Contributor Author

after testing and feedback, this doesn't seem to be worthwhile to pursue

@ThatGuyThe
Copy link

Personally, i quite enjoyed playing with it, id say it just needs a few tweaks and the ability to opt out for the 500 people complaining that turning down the volume to 0 does not disable it

@CGosling
Copy link
Contributor

CGosling commented Sep 4, 2024

As someone who was initially sceptical, this feature won my over due to QoL improvement in more chaotic roles, ambience during serious moments and accessibility for users with disabilities. This merely needed some tweaking and perhaps a larger opt outfeature when setting up a character.

@Skatuk
Copy link

Skatuk commented Sep 4, 2024

It doesn’t fit into the game because it doesn’t captivate the tone that your trying to portray and it just makes you look goofy and pretty much a joke when being listened to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants