Collapsible Platform Edges. #7096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i lack that coding capability
github-actions
bot
added
Sprites
- Instead of 9 seconds they take 30 seconds.
Venuska1117
changed the title
Venuska1117
changed the title
github-actions
bot
added
the
Sound
- Fixed Layers issues. - Changed Explosion treshold for breaking. - Added 2 types of platform breaking sound. - Examinating broken platform give now feedback that its destroyed in description. - Separated "Indestructable" and "Broken" to give two different feedbacks depending on platform status.
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
Venuska1117
force-pushed
the
breakable-edges
branch
from
160521a
to
5640806
Compare
…reakable-edges
- Changed paths for all platforms, so they can play sound attached to their parent. - Add "7096-platforms-paths.txt" to allow other people to update their platforms paths.
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
- Fixed one wrong typo inside patforms.dm - changed "7096-platforms-paths.txt" order of platform_cut, so var edited icon_states are replaced fist before changed to base type. - Run BigRed trough updatepath to fix merge conflict.
- Removed old paths in platforms.dm used to check issues in previous update.
…reakable-edges
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Drulikar
approved these changes
Nov 7, 2024
Drulikar
added
Testmerge Candidate
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
cm13-github
added a commit
that referenced
this pull request
Nov 7, 2024
cm13-github
added a commit
that referenced
this pull request
Nov 7, 2024
cm13-github
added a commit
that referenced
this pull request
Nov 7, 2024
3 tasks
This was referenced Nov 8, 2024
cm13-github
added a commit
that referenced
this pull request
Nov 9, 2024
Drulikar
added
Mapping Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!!DISCLAIMER!!!
I am very bad at spriting and i am not joking.
I recommend to put this PR in Testmerge, so i can find issues caused by swapping paths and find oversights with sprites.
About the pull request
I am working on rework of Kutjevo #6971
Fixes: #7049
Because i plan to add elevation by using large quantities of platform edges, i tough it will be too annoying for players, who are keep dying, like xenos and marines because edge stopped them for 1-2 seconds.
Edit: Its 70% done, i just lack sprites. (made only one platform sprite set for demonstration in videos below)
Edit(07.09): I was forced to change paths of platforms so they can play different sounds depending on what they are made of.
Edit(15.09): Finally done sprites, now time to wait.
Edit(21.09): thanks to Doubleumc | Casey Walton and cuberound for having time explain me some code related terms, thanks you both for that.
Edit(15.10): Added Stair variant of Platform with own sprites and broken states.
Explain why it's good for the game
Allow game to be more dynamic by adding little more "terrain destruction" that will benefit gameplay and mappers who like to keep Map elevation but they are worried that platform edges will make experience negative. (people complain a lot)
Testing Photographs and Procedure
Click HERE to see Videos
Platforms before destruction:
Platforms after destruction:
How it work and sound when xeno break them:
2024-09-15.12-04-01.mp4
How it will work for Explosions:
2024-09-15.12-00-33.mp4
Changelog
🆑 Venuska1117
code: Added ability to Destroy Platform Edges by xenos on "Disarm" intent, now depending on xenos "size" they can break Platform Edges quicker or Slower, Now Explosives have chance to destroy Platform Edges by depending on how strong explosion is.
imageadd: Added Sprites for Broken Platforms Edges.
soundadd: Added Sound for Breaking "Stone" Edges.
/:cl: