Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project ARES: Fix gas duration #7119

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Sep 5, 2024

About the pull request

As title

Changelog

🆑
fix: Fixes the duration of the AI Core nerve gas, will no longer last a full minute.
/:cl:

@realforest2001 realforest2001 added this to the Project ARES milestone Sep 5, 2024
@github-actions github-actions bot added the Fix Fix one bug, make ten more label Sep 5, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless i'm missing something

code/game/machinery/ARES/ARES_interface.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft September 10, 2024 09:15
@realforest2001 realforest2001 marked this pull request as ready for review September 10, 2024 22:11
@@ -180,5 +180,5 @@
if(!gas_holder || welded)
return FALSE
playsound(loc, 'sound/effects/smoke.ogg', 25, 1, 4)
gas_holder.set_up(radius, 0, get_turf(src), null, 10 SECONDS)
gas_holder.set_up(radius, 0, get_turf(src), null, 10)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deliberately removed the SECONDS multiplier because it's breaking the maths. Time is ticking down one per second rather than per tick which is why gas is currently lasting near 2 minutes.

Copy link
Contributor

@kiVts kiVts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forest is right

@kiVts kiVts added this pull request to the merge queue Sep 17, 2024
Merged via the queue into cmss13-devs:master with commit b228b68 Sep 17, 2024
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants