Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a version of the CO armor without pauldrons #7143

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TheGamerdk
Copy link
Contributor

@TheGamerdk TheGamerdk commented Sep 10, 2024

About the pull request

This is based on the old sprite, and is a stat-identical version of the normal CO armor, minus the pauldrons.

Nessie is behind this, please refer criticism that way. (Unless it's the code, that's on me)

Explain why it's good for the game

More choices for drip baby!

Testing Photographs and Procedure

Screenshots & Videos

image

Can only pick 1:
image

Worn:
image

Changelog

🆑
add: COs have a new variant of their armor to choose from
/:cl:

@cmss13-ci cmss13-ci bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Sep 10, 2024
Copy link
Contributor

@Blundir Blundir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not really support it for consistency reasons, if you want to make pauldron-less version, use the main CO armor for it, the previous officer armor was a placeholder, inform the spriter

@Blundir Blundir marked this pull request as draft September 10, 2024 18:30
@TheGamerdk TheGamerdk marked this pull request as ready for review September 11, 2024 09:35
@TheGamerdk
Copy link
Contributor Author

I do not really support it for consistency reasons, if you want to make pauldron-less version, use the main CO armor for it, the previous officer armor was a placeholder, inform the spriter

Updated the sprites. I can update the in-game example screenshots if you want, but seems unnecessary

@efzapa
Copy link
Contributor

efzapa commented Sep 18, 2024

wouldn't it be better to just make it togglable like how you can roll down your uniform since there is no stat difference anyways

no need for item bloat here tbh

@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Oct 27, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Oct 27, 2024
@Blundir Blundir added Stale Exempt PR can't go stale Sprites Approved confirmed no stray pixels Sprites Frozen Merge this and you will make the spritetainers angry. and removed Stale beg a maintainer to review your PR labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Frozen Merge this and you will make the spritetainers angry. Sprites Remove the soul from the game. Stale Exempt PR can't go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants