-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a version of the CO armor without pauldrons #7143
base: master
Are you sure you want to change the base?
Conversation
code/game/machinery/vending/vendor_types/crew/commanding_officer.dm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not really support it for consistency reasons, if you want to make pauldron-less version, use the main CO armor for it, the previous officer armor was a placeholder, inform the spriter
Updated the sprites. I can update the in-game example screenshots if you want, but seems unnecessary |
wouldn't it be better to just make it togglable like how you can roll down your uniform since there is no stat difference anyways no need for item bloat here tbh |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
This is based on the old sprite, and is a stat-identical version of the normal CO armor, minus the pauldrons.
Nessie is behind this, please refer criticism that way. (Unless it's the code, that's on me)
Explain why it's good for the game
More choices for drip baby!
Testing Photographs and Procedure
Screenshots & Videos
Can only pick 1:
Worn:
Changelog
🆑
add: COs have a new variant of their armor to choose from
/:cl: