Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squad Prep Weapon Vendors now scale with number of marines #7153

Merged
merged 3 commits into from
Oct 5, 2024

Conversation

private-tristan
Copy link
Contributor

@private-tristan private-tristan commented Sep 12, 2024

About the pull request

latejoining now adds to the stock of squad vendors, meaning that latejoiners will no longer suffer from a lack of ammo due to someone emptying out most of the vendors of ammo.

I greatly reduced the starting stock of ammo to compensate, you can see my quick testing below for "number of marines joined" vs "number of mags added", but in short, every 3rd player adds 1 mag to every prep vendor (12 per prep). 65 marines joining will bring the number of mags to their previous starting amount (10 -> 25)

Explain why it's good for the game

Joining onto 3 hour rounds only to find that all the m41a ammo has been taken and sent to FOB kinda sucks, I don't want to visit requisitions for basic ammo (or loot the shooting range).

Testing Photographs and Procedure

1 marine:

image

3 marines:

image

50 marines:

image

Changelog

🆑
balance: Prep Weapon Vendors now scale with number of marines.
balance: Prep Weapon Vendor "base" stock is lowered to compensate.
/:cl:

@cmss13-ci cmss13-ci bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Sep 12, 2024
@hislittlecuzingames
Copy link
Contributor

why did you reduce the initial amount?
This looks to be less than it was before despite the ability to scale.

@private-tristan
Copy link
Contributor Author

If I didn't reduce the initial stock, assuming 50 marines join, the preps would have roughly 50 mags per vendor (and there are 24 vendors), which is a little absurd seeing how on some rounds there's 100+ marine players.

Also dynamic scaling is based on the initial stock. By reducing initial amounts control how many marines need to join per 1 mag to be added to all vendors (3 at the current rate.)

@harryob harryob added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Oct 5, 2024
@harryob harryob added this pull request to the merge queue Oct 5, 2024
Merged via the queue into cmss13-devs:master with commit be7e46d Oct 5, 2024
27 checks passed
cmss13-ci bot added a commit that referenced this pull request Oct 5, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2024
# About the pull request
When I made #7153 I decreased the starting mk2 and m39 mags too much, so
i'm increasing them again
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game
I want more mk2 mags in prep vendor so that I don't need to loot
multiple vendors for ammo.
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
balance: Increased the starting amount of mk2 and m39 mags in prep
vendors
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants