Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revolver changes (goldendarkness edition) #7163

Closed
wants to merge 1 commit into from

Conversation

Rem1-code
Copy link
Contributor

@Rem1-code Rem1-code commented Sep 14, 2024

About the pull request

Makes m44 heavy revolver ammo give a screen shake effect. Revive and modernization of #4014

Explain why it's good for the game

Heavy revolver ammo is currently the worst sidearm ammo in the game. the damage is pitiful, and it's main use reason, the stun, was removed and replace with a comically bad slow. It's now at the point where it most likely helps xenos more then it hurts them. A screenshake effect allows it to be a good "fuck off" weapon without returning to toxic stun combat or being OP.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Heavy revolver ammo now inflicts a screen shake effect, as opposed to a small slow.
/:cl:

@cmss13-ci cmss13-ci bot added the Feature Feature coder badge label Sep 14, 2024
@Rem1-code Rem1-code changed the title shake revolver changes (goldendarkness edition) Sep 14, 2024
@kiVts kiVts added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Sep 19, 2024
@Flerpin
Copy link

Flerpin commented Sep 22, 2024

Careful with the screenshake. I think one critique I heard about screenshake being removed from heavy revolvers was that you could use it to screen shake T3s as they're trying to leap a way, fucking up their leap in the process. (Not unless T3s are immune to them)

@private-tristan
Copy link
Contributor

the screenshake doesn't check for mob size, T3s will have the same amount of screenshake as a lesser drone.

@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Oct 27, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Oct 27, 2024
@Drulikar
Copy link
Contributor

I do not see this as an improvement, only see this as a nerf when it doesn't need one, and in general very much dislike screenshake especially during combat.

@Drulikar Drulikar closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants