Extracts some specific effects properties into an element, adds afterimage effect #7220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also adds an afterimage effect, no applications yet
boskoramen
force-pushed
the
effects-stuff
branch
from
f96d098
to
b451aba
Compare
harryob
approved these changes
Oct 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
…nt, adds afterimage effect ) (#7348) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> # About the pull request Fixes being able to attack blood spatter with merge #7220 # Explain why it's good for the game TERRIBLE BUG BREAKS IMPORTANT GAME MECHANICS # Testing Photographs and Procedure </details> # Changelog 🆑 lolvax1 fix: fixes blood spatter being clickable /🆑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Instead of having subtypes like temp_visuals, use elements to configure effects.
Also added an afterimage effect for future use.
Explain why it's good for the game
Composition > inheritance
Testing Photographs and Procedure
Screenshots & Videos
With
fading_durationof 1.5 secondsafterimage2.mov
Changelog
🆑 TheDonkified
add: Afterimage effect to be used by others. Currently not in use by anything.
/:cl: