Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Extracts some specific effects properties into an element, adds afterimage effect" #7347

Closed

Conversation

Strobia
Copy link
Contributor

@Strobia Strobia commented Oct 20, 2024

Reverts #7220
This heavily breaks the PB mechanic due to marines being able to attack the blood spray off of their targets https://streamable.com/y9x9f4

🆑
fix: REMOVES BROKEN PR
/🆑

@cmss13-ci cmss13-ci bot added the Missing Changelog Maintainers always document their changes. label Oct 20, 2024
@irakligabunia

This comment was marked as abuse.

@cmss13-ci cmss13-ci bot added Fix Fix one bug, make ten more and removed Missing Changelog Maintainers always document their changes. labels Oct 20, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reversion looks unnecessary.

Consider instead adding mouse_opacity = MOUSE_OPACITY_TRANSPARENT to the effects that were converted from code\game\objects\effects\temporary_visuals by that PR.

@Strobia Strobia closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants