Prevent tackle sound from Queen corpses #7225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmss13-ci
bot
added
Missing Changelog
|
uhh... if another queen evos won't it make the other queen corpse start knocking down again/ |
Looking after it |
|
Just check mob's state instead??? queen.stat == DEAD Or even better unregister the signal from the mob on queen's death |
realforest2001
requested changes
Sep 30, 2024
| @@ -443,7 +443,7 @@ | |||
| /mob/living/carbon/xenomorph/queen/proc/check_block(mob/queen, turf/new_loc) | |||
| SIGNAL_HANDLER | |||
| for(var/mob/living/carbon/xenomorph/xeno in new_loc.contents) | |||
| if(xeno.hivenumber == hivenumber) | |||
| if(xeno.hivenumber == hivenumber && hive.living_xeno_queen) | |||
There was a problem hiding this comment.
Suggested change
| if(xeno.hivenumber == hivenumber && hive.living_xeno_queen) | |
| if(xeno.hivenumber == hivenumber) |
There was a problem hiding this comment.
Done, thanks for the suggestion!
…ss13 into fix-tackle-dead-queen
realforest2001
approved these changes
Oct 6, 2024
|
What a problem to unreg signal on proc death? |
|
by the way, you need to mark your prs as ready to review when you'd like a maintainer to look over and merge
|
harryob
requested changes
Oct 26, 2024
harryob
approved these changes
Oct 26, 2024
harryob
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes Issue #7223
Verifying if the queen is dead on check_bloc to prevent playing the sound.
Tested on almayer with dead queen body, dead drone body ade dead crusher body
Explain why it's good for the game
Fixing bug to improve game quality
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Test: https://www.youtube.com/watch?v=kn_JU-B11pg
Changelog
🆑
fix: Prevent tackle noises from Queen corpses
/:cl: