Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel's Slowing Spit can now drain Medical and Research chems on hit #7230

Merged
merged 4 commits into from
Oct 27, 2024

Conversation

TheKillfish
Copy link
Contributor

@TheKillfish TheKillfish commented Sep 28, 2024

About the pull request

Adds options for the apply_neuro effect used by neurospit to drain Medical Reagents and Generated Reagents on hit. Primarily intended for Sentinel, however Queen can be also be made to use it. Drain, for now, is based off effect power, meaning 1u for each applicable chem per hit in Sent's case and 2u if Queen is allowed to.

The draining effects have been ordered such that Med draining is blocked by Neuroblocking traits while Stims will always be drained.

Explain why it's good for the game

Stims are currently very unfair for Xenos to deal with as they have no counter save for getting a King, and so far they have not been nerfed particularly much. Sentinel meanwhile has been suffering from lack of content for a while. This sorts both problems, giving Xenos a more attainable counter to stim usage and giving Sentinel a new purpose; draining stimmed Marines.

I added medchem draining as an option since most things that purge reagents apply to all reagents good and bad, and not just a specific subtype like what I've done here. This gives backed-in modularity, and modularity es gud.

Changelog

🆑 Killfish
balance: Added Stim and Medical Chem draining effects to Sentinel's Slowing Spit.
/:cl:

@cmss13-ci cmss13-ci bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Sep 28, 2024
@TheKillfish TheKillfish marked this pull request as ready for review September 29, 2024 07:40
@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Oct 27, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Oct 27, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interested to see how this plays out

@harryob harryob added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Oct 27, 2024
@harryob harryob added this pull request to the merge queue Oct 27, 2024
Merged via the queue into cmss13-devs:master with commit 3c505f5 Oct 27, 2024
31 checks passed
cmss13-ci bot added a commit that referenced this pull request Oct 27, 2024
@TheKillfish TheKillfish deleted the anti-stim-sent-time branch October 31, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants