Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Scandinavian as a language option in the traits menu #7247

Merged
merged 6 commits into from
Oct 5, 2024

Conversation

WazLach
Copy link
Contributor

@WazLach WazLach commented Sep 30, 2024

About the pull request

I have added Scandinavian as a language in the traits option. The syllables used are mostly the same as the German ones after being translated into Norwegian, I chose Norwegian since that's the one I'm most familiar with. Scandinavian languages are lumped together because:
A: They are mutually intelligible.
B: They are hard to distinguish if you don't speak it.
C: I assume with time the languages have only gotten more similar.
D: It gives an option for characters from multiple countries to have a language.

NOTE: The key for the language is currently set at 0, as all other numbers are taken. I do not like this, I would rather it be set to something else, however I do not know all the keys, if there is a better suggestion feel free to change it.

Explain why it's good for the game

Allows characters more roleplay options, while German exists and is similar to Scandinavian languages, they are distinct and it does restrict roleplay options. I generally believe that having more options to flesh out a character is good, especially when it doesn't impact the game itself majorly.

Testing Photographs and Procedure

Screenshots & Videos
Scandinavian.Language.Test.Video.-.Made.with.Clipchamp.mp4

Changelog

🆑 lokideslimee
add: Added Scandinavian as a language
code: Coded in the Scandinavian
code: Added Scandinavian as a language for mobs that should know the language
/:cl:

@cmss13-ci cmss13-ci bot added Feature Feature coder badge Code Improvement Make the code longer labels Sep 30, 2024
@WazLach
Copy link
Contributor Author

WazLach commented Sep 30, 2024

Note that this is my first actual PR so if there's any feedback I'd love to hear it.

@TheManWithNoHands
Copy link
Contributor

Just and fyi. You can make the language key use letters too, not just numbers. Should give more options for you to use then 0

@cmss13-ci cmss13-ci bot added the UI deletes nanoui/html label Sep 30, 2024
@WazLach
Copy link
Contributor Author

WazLach commented Sep 30, 2024

I've added the colour properly now, I found it readable, though if others have trouble I'd like to know. Also changed some of the syllables in the list, since some of them weren't great, the result should pass as Scandinavian mumbo jumbo better.

Also, I haven't changed the key as I'm not fully aware of which ones are in use, or which one would be appropriate, it's not hard to change though, so if anyone really wants 0 in the future that can be done.

@WazLach
Copy link
Contributor Author

WazLach commented Oct 2, 2024

A final note the keys, I'm leaving it as "0" since there's not many other options, other than symbols such as "!" which I want to avoid using for consistency, though I've tested it and it does seem to work.

/datum/language/scandinavian
name = LANGUAGE_SCANDINAVIAN
desc = "While not technically one language, Scandinavian languages have grown similar and are nearly indistinguishable from one another unless you actually know the languages."
speech_verb = "blubbers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh oh

@harryob harryob added this pull request to the merge queue Oct 5, 2024
Merged via the queue into cmss13-devs:master with commit f1cadb8 Oct 5, 2024
27 checks passed
cmss13-ci bot added a commit that referenced this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Feature Feature coder badge UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants