Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Resin Salve only go on CD after successful activations, not attempted ones #7301

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tyranicranger4
Copy link
Contributor

@Tyranicranger4 Tyranicranger4 commented Oct 12, 2024

About the pull request

#6847 introduced a cooldown to the healer drone's salve ability. Specifically, it was set to apply on an attempted activation of the ability, not just on a successful activation of it.

This has made the usage of the ability, and thus healer in general, feel more clunky. It's not an ability like warrior's lunge where the way the cooldown is applied has considerable balancing concerns, so this moves the cooldown to successful activations only.

Also removes the notification for the resin salve cooldown expiring. It's a 0.5 second cooldown, it doesn't need a notification.

Explain why it's good for the game

QoL. Makes the main ability of the healer caste feel less clunky and overall nicer to use.
Considering that the old version of this ability didn't even have a cooldown, I don't see this affecting balance in any meaningful way.

Testing Photographs and Procedure

Screenshots & Videos

https://streamable.com/wuyf3t

Changelog

🆑
qol: Makes Resin Salve only go on CD after successful activations, not attempted ones
qol: Removes the chat notification for Resin Salve going off CD (it's a 0.5 second CD)
/:cl:

@cmss13-ci cmss13-ci bot added the Quality of Life Make the game harder to play label Oct 12, 2024
@@ -124,6 +124,8 @@
if(target_is_healer)
damage_taken_mod = 1

for(var/datum/action/xeno_action/activable/apply_salve/source_action in usr.actions)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for(var/datum/action/xeno_action/activable/apply_salve/source_action in usr.actions)
for(var/datum/action/xeno_action/activable/apply_salve/source_action in actions)

@harryob harryob marked this pull request as draft October 26, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants