Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Funny Wall Bug #7359

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Fixes Funny Wall Bug #7359

merged 1 commit into from
Oct 26, 2024

Conversation

Comxy
Copy link
Contributor

@Comxy Comxy commented Oct 22, 2024

About the pull request

This PR stops wall turfs from reflecting bonus damage to mobs. This PR is tested and makes sure the damage multiplier isn't accounted for when damage gets reflected.

Explain why it's good for the game

Yesterday I got one shot by a XM51 as hivelord at close if not full health. I was wondering what happened and remembered that XM51 does bonus damage on walls and I build one under myself as hivelord. It turns out you can kill a queen in one shot with XM51 if they are in a resin wall.

Testing Photographs and Procedure

I would make a video if I knew how to but you can test it for yourself pretty easily.

Changelog

🆑
fix: Fixes wall damage multipliers from reflecting to mobs.
/:cl:

@cmss13-ci cmss13-ci bot added the Fix Fix one bug, make ten more label Oct 22, 2024
@cuberound
Copy link
Contributor

cuberound commented Oct 23, 2024

it looks like your fix means that when there is the mob instead of hitting both for wall dmg you hit both for mob dmg?

@Comxy
Copy link
Contributor Author

Comxy commented Oct 24, 2024

it looks like your fix means that when there is the mob instead of hitting both for wall dmg you hit both for mob dmg?

Yeah, it removes the wall multiplier, the damage goes only to the mob with the normal amount now

@harryob harryob added this pull request to the merge queue Oct 26, 2024
Merged via the queue into cmss13-devs:master with commit 1de895c Oct 26, 2024
29 checks passed
cmss13-ci bot added a commit that referenced this pull request Oct 26, 2024
@Comxy Comxy deleted the turf_reflection_bug branch October 27, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants