Soro Shivas area fixes and tweaks #7488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmss13-ci
bot
added
Mapping
Drulikar
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Soro's oviable areas:
Red X please make not oviable. Yellow please consider making oviable. The question marked area should either be connected or not oviable.
Shiva's seems acceptable:
If you wanted the same code I'm using to visually check:
patch.diff.txt
|
added yellow areas. The red X's are oviable because of https://github.com/Nanu308/cmss13/blob/1ce880bb79d215641f1feb7aa48a31208100957a/code/game/objects/effects/landmarks/landmarks.dm#L238-L243. These areas have xeno_hive_spawn landmarks for XvX. |
XvX spawns are for a different gamemode, those areas should not be oviable in Distress mode. Distress mode is specifically to keep xenos from rushing down marines and so forth. Besides that see Drathek's comment |
Drulikar
approved these changes
Nov 5, 2024
Merged
Drulikar
added
the
Balance Approved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
# About the pull request This PR is a follow up to #7363 and #7488 where it was discovered that the XvX hive landmarks were being used as an area to allow ovi meaning distress signal was getting areas not intended to be oviable. This also makes it so the ovi restriction does not apply to XvX (all areas will allow it). Oviable areas were also expanded on Kutjevo, Shivas, Tijent Dam, Chance's Claim, and Fiorina. # Explain why it's good for the game Ovi restrictions are intended to disallow hives next to LZs, this fixes that. It also expands the areas oviable at the start of the game on Kutjevo, Shivas, Trijent Dam, Chance's Claim, and Fiorina so there is more variety in where an initial hive can be place. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary>                Testmerge with Hybrisa:  </details> # Changelog :cl: Drathek balance: Fix XvX landmarks being used for roundstart oviable locations balance: Roundstart oviable locations are expanded on Kurjevo, Shivas, Trijent Dam, Chances's Claim, and Fiorina fix: XvX now makes all areas oviable /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes incorrect shivas areas from the rework + incorporates super small deck area into other areas
Removes "hallway" areas from soro and incorporates them into surrounding areas. Combines 3 adjacent canteen areas into 1.
"Hallway" areas were added to allow CAS inside buildings. This effectively allowed you to CAS inside any of the colony buildings but required you to know where these super special areas were in the rooms or hunt for them by examining the floor. Now the whole think is just CASable which it basically already was because of how offsets work.
Explain why it's good for the game
Bugs/oversights bad. Power going out in only half of a room because of weird area shenanigans is bad. Now areas make logical sense and the APCs tied to them are in sensible locations.
Testing Photographs and Procedure
before
after
Changelog
🆑 BOBAMA
fix: bugged Shivas areas
maptweak: Removed Sorokyne "hallway areas"
balance: Areas on Sorokyne that were only CASable because of the "hallway areas" can now just be CASd
/:cl: