Fix autofire exploit #8208
Open
Fix autofire exploit #8208
+23
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
I am unsure of what was being fixed in ae2d7fa#diff-fb39f337690c5cab8f459bac12321035fe3e5e3e5423429ee19c83bc114e745eR574 but the chambered bullet needs to either be fired or deleted rather than have the chambered ammo keep repeating
apply_bullet_effectsandapply_bullet_scatter. Alternatively the loc check could be done much earlier in the call, but I don't see any reason why we shouldn't just fire the gun.Explain why it's good for the game
No more cheesy instakills!
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/kLYFs2NBag4
Changelog
🆑 Drathek
fix: Fixed an autofire exploit
/:cl: