New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JERC #53

Merged

kmohrman merged 48 commits into main from jec

Oct 7, 2024

Contributor

MatthewDittrich commented Oct 4, 2024 •

edited by kmohrman

Loading

In this PR:

Implementation of the JEC and JER corrections for Run 2 and Run 3 using correctionlib
R3 jet veto maps
Unrelated updates also included in this PR: Also include prefixes for running with file copy at HPG

New refs with all updates are: 4.57517, 2.49108, 5.12477

This is the version of the analysis that will be frozen for pre-approval.

MatthewDittrich added 30 commits

July 24, 2024 07:08


          JSONs for corrections

3ff31d9


          Initial JEC stuff

b3672d8

JEC

d181183


          More JEC

815fbca


          JEC Stuff

0131f37

JEC

f29ac6b


          Jer and Jec corrections

6952e4e


          Temp Fix

b70396a


          Smear Debugging

e03c9fa


          Fixed Run2 Data Samples

a2279f0


          Run2 Test

5702fd5


          JEC UP DOWN Issue

aaea46d


          Small edits

8fbb3e1


          Merge branch 'main' into jec

fe7f610


          Input Samples

0da2a4d


          DataCard making

d25d455


          DataCard Maker

de99eba


          Input Samples

80d8f22


          Main Merge

9d30a78


          Small Changes

2b8e21d


          Small Changes

682de49


          Changes

53ade77


          Small Edits

f56a1e0


          Main Merge

d625561


          Small Edits

695f82c


          Andrea Method

c2c90e0


          Syncing

c1bf63e


          Final Chnages

4d3ad02


          Data Fix

05a4080


          Main Merge

44262a7

kmohrman reviewed

View reviewed changes

ewkcoffea/data/wwz_jerc/2016APV_jerc/fatJet_jerc.json Outdated Show resolved Hide resolved

kmohrman reviewed

View reviewed changes

ewkcoffea/data/wwz_jerc/jer_smear.json Outdated Show resolved Hide resolved

kmohrman reviewed

View reviewed changes

input_samples/cfgs/wwz_analysis/samples_4lskim_2022_v1.cfg Outdated Show resolved Hide resolved

kmohrman reviewed

View reviewed changes

input_samples/cfgs/wwz_analysis/samples_4lskim_run3_v1.cfg Outdated Show resolved Hide resolved

kmohrman reviewed

View reviewed changes

ewkcoffea/modules/corrections.py Outdated Show resolved Hide resolved

MatthewDittrich and others added 3 commits

October 4, 2024 11:55


          Making HPG Work

460e283


          Changes

fa8a2d4


          Restore master branch naming

40b4e89

kmohrman mentioned this pull request

Remove or harmonize jerc files #54

Open


          Merge remote-tracking branch 'origin/main' into jec

3f370b3

kmohrman reviewed

View reviewed changes

analysis/wwz/wwz4l.py Outdated Show resolved Hide resolved

kmohrman reviewed

View reviewed changes

analysis/wwz/wwz4l.py Show resolved Hide resolved

kmohrman reviewed

View reviewed changes

analysis/wwz/wwz4l.py Show resolved Hide resolved

MatthewDittrich added 2 commits

October 6, 2024 13:37


          Veto Maps and Addressing Comments

4a68372


          Flake 8 is the enemy

234114b

kmohrman reviewed

View reviewed changes

analysis/wwz/wwz4l.py Show resolved Hide resolved

Collaborator

kmohrman commented Oct 6, 2024

For reference, this is the yield difference we have for R2 for applying the JERC corrections:

Collaborator

kmohrman commented Oct 6, 2024

For reference, this is the yield difference we have for R3 for applying the JERC corrections:

Collaborator

kmohrman commented Oct 6, 2024

For reference, this is the yield difference we have for R3 for applying the Jet veto maps on top of the JERC corrections (with respect to just JERC corrections):

kmohrman added 7 commits

October 6, 2024 16:09


          Update ref yields for jerc and jet veto maps

bf300e2


          Use R3 as ref

b578f57


          Clean up


          Clean up datacard maker and ylds, pull out 27 jec vars

5c18630


          Flake8 why do you care about trailing spaces in comments

150df3d


          Do we need to checkout tc clib_jme for now

10277bd


          Update R3 ref after jet veto maps

d905d37

kmohrman mentioned this pull request

2023BPix Jet Veto Map Issue #40

Open


          Clean up spaces

6d1c508

kmohrman merged commit 7cfbaee into main

2 checks passed

kmohrman deleted the jec branch

October 7, 2024 16:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet