feat: support reading form csv file #550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clundro <[email protected]>
infdahai
changed the title
|
duckdb sql just supports so we can only use 'create table' and then 'copy from' to do this task. |
skyzh
reviewed
Mar 26, 2023
CMakeLists.txt
Outdated
| @@ -311,6 +311,7 @@ add_custom_target(submit-p2 | |||
| ) | |||
|
|
|||
| set(P3_FILES | |||
| "src/include/execution/executors/copy_file_executor.h" | |||
There was a problem hiding this comment.
should not include in submission files, because it will not be modified by students
| private: | ||
| const PhysicalCopyFileNode *plan_; | ||
| } | ||
| } // namespace bustub |
There was a problem hiding this comment.
probably need to add a new line to avoid lint warnings
|
|
||
| protected: | ||
| auto PlanNodeToString() const -> std::string override { | ||
| return fmt::format("PhysicalCopy {{ file_path={} }}", path_); |
There was a problem hiding this comment.
In BusTub we don't add Physical to the plan node name
| namespace bustub { | ||
| class BaseCsvReader { | ||
| public: | ||
| BaseCsvReader(); |
There was a problem hiding this comment.
sorry, I still read the duckdb code and I'm a little slow to catch on that.
Signed-off-by: clundro <[email protected]>
1. build error => copyfrom executor needs to insert table heap. Signed-off-by: clundro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #404
status: (don't need to review, still be coding)
material impl ref: duckdb, risinglight，
copy syntax specification: copy statement
expected behavior:
task:
get bind_type and create file copy plan.(file path,file format)
csv file: read file based on path and get columns.