Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add read guard test #627

Merged
merged 1 commit into from
Oct 17, 2023
Merged

chore: add read guard test #627

merged 1 commit into from
Oct 17, 2023

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Oct 17, 2023

an unwritten contract (actually we wrote it in the BPM comment) of page guard

@skyzh skyzh requested a review from yliang412 October 17, 2023 03:49
yliang412
yliang412 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@skyzh skyzh merged commit 9b1d2ee into master Oct 17, 2023
3 checks passed
@skyzh skyzh deleted the skyzh/p2-test-better branch October 17, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yliang412 yliang412 yliang412 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyzh @yliang412