Skip to content

Commit

Permalink
deleted append_group
Browse files Browse the repository at this point in the history
  • Loading branch information
wangpatrick57 committed Dec 30, 2024
1 parent 17f89ff commit e3ac705
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 10 deletions.
2 changes: 1 addition & 1 deletion benchmark/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
@click.group(name="benchmark")
@click.pass_obj
def benchmark_group(dbgym_workspace: DBGymWorkspace) -> None:
dbgym_workspace.append_group("benchmark")
pass


benchmark_group.add_command(tpch_group)
Expand Down
2 changes: 1 addition & 1 deletion benchmark/job/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
@click.group(name="job")
@click.pass_obj
def job_group(dbgym_workspace: DBGymWorkspace) -> None:
dbgym_workspace.append_group("job")
pass


@job_group.command(name="tables")
Expand Down
2 changes: 1 addition & 1 deletion benchmark/tpch/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
@click.group(name="tpch")
@click.pass_obj
def tpch_group(dbgym_workspace: DBGymWorkspace) -> None:
dbgym_workspace.append_group("tpch")
pass


@tpch_group.command(name="tables")
Expand Down
2 changes: 1 addition & 1 deletion dbms/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
@click.group(name="dbms")
@click.pass_obj
def dbms_group(dbgym_workspace: DBGymWorkspace) -> None:
dbgym_workspace.append_group("dbms")
pass


dbms_group.add_command(postgres_group)
2 changes: 1 addition & 1 deletion dbms/postgres/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
@click.group(name="postgres")
@click.pass_obj
def postgres_group(dbgym_workspace: DBGymWorkspace) -> None:
dbgym_workspace.append_group("postgres")
pass


@postgres_group.command(
Expand Down
5 changes: 0 additions & 5 deletions util/workspace.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ def __init__(self, dbgym_workspace_path: Path):
), f"DBGymWorkspace has been created {DBGymWorkspace._num_times_created_this_run} times. It should only be created once per run."

self.base_dbgym_repo_path = get_base_dbgym_repo_path()
self.cur_path_list: list[str] = ["dbgym"]
self.app_name = (
"dbgym" # TODO: discover this dynamically. app means dbgym or an agent
)
Expand Down Expand Up @@ -295,10 +294,6 @@ def open_and_save(self, open_path: Path, mode: str = "r") -> IO[Any]:
# Open
return open(open_path, mode=mode)

# `append_group()` is used to mark the "codebase path" of an invocation of the CLI. The "codebase path" is explained further in the documentation.
def append_group(self, name: str) -> None:
self.cur_path_list.append(name)


def get_workspace_path_from_config(dbgym_config_path: Path) -> Path:
"""
Expand Down

0 comments on commit e3ac705

Please sign in to comment.