This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
[WIP] Physical props #173
Draft
AveryQi115
wants to merge
17
commits into
main
Choose a base branch
from
phy_props
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Physical props #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AveryQi115
commented
Apr 30, 2024
•
edited
Loading
edited
- basic framework
- default physical properties builder (without any constraints)
- test default builder
- ordering physical properties builder (Sort -> order)
- testcases
- code reconstruction
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
Why is it that we needed to incorporate the notion of a I am predicting it may be because we are lacking separation of the phases that apply transformation rules and implementation rules? |
No, it’s not related to separation of transformation rules and impl rules. It’s a standard way to do this, just see calcite and cockroaches code. They both have a notion of logically equivalent and physically equivalent subset in logically equivalent set |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.