Skip to content

(feat) Finalize Semantic Analyisis & Add Type Annotations #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2025

Conversation

AlSchlo
Copy link
Collaborator

@AlSchlo AlSchlo commented Apr 12, 2025

main change

Finalizes semantic analysis by checking for field number mismatches in Patterns and Constructors.
Displays an error message during the from_ast phase, as follows:

image

extra changes

  • I added all type annotations I could during the from_ast phase, to simplify type inference.
  • Added the none type, which inherits from Option.

@AlSchlo AlSchlo requested review from connortsui20, yliang412 and SarveshOO7 and removed request for connortsui20 April 12, 2025 12:43
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.81637% with 41 lines in your changes missing coverage. Please review.

Project coverage is 79.3%. Comparing base (84d2f48) to head (f6c0220).

Files with missing lines Patch % Lines
optd-dsl/src/analyzer/error.rs 43.7% 27 Missing ⚠️
optd-dsl/src/analyzer/from_ast/expr.rs 97.8% 5 Missing ⚠️
optd-dsl/src/analyzer/types.rs 95.0% 5 Missing ⚠️
optd-dsl/src/analyzer/from_ast/pattern.rs 96.6% 4 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
optd-dsl/src/analyzer/from_ast/converter.rs 98.4% <100.0%> (ø)
optd-dsl/src/cli/main.rs 0.0% <ø> (ø)
optd-dsl/src/compile.rs 0.0% <ø> (ø)
optd-dsl/src/analyzer/from_ast/pattern.rs 94.0% <96.6%> (+1.5%) ⬆️
optd-dsl/src/analyzer/from_ast/expr.rs 94.5% <97.8%> (+0.3%) ⬆️
optd-dsl/src/analyzer/types.rs 97.9% <95.0%> (-0.7%) ⬇️
optd-dsl/src/analyzer/error.rs 29.6% <43.7%> (+3.3%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlSchlo AlSchlo merged commit 42f8cfb into main Apr 15, 2025
12 checks passed
@AlSchlo AlSchlo deleted the alexis/finalize-semantic-analysis branch April 15, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants