Skip to content

[Refactor] Clean server integration tests #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Jun 7, 2022

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

Extracts the really nice test refactors Katie did in #923.

Why? That branch is experimental and might not be merged. We definitely want to keep these refactors, however.

Addresses #897

krivard and others added 2 commits June 6, 2022 18:08
Add cheap utility methods to CovidcastRow
used in integration tests

Passing: i/server/test_covidcast_endpoints.py

Propagate method rename

passing: all integration tests

Add covidcast acquisition test utility class

Refactor remaining tests
@dshemetov dshemetov requested a review from krivard June 7, 2022 19:21
@dshemetov dshemetov added good first issue refactor Substantial projects to make the code do the same thing, better. labels Aug 23, 2022
@dshemetov dshemetov closed this Aug 27, 2022
@dshemetov
Copy link
Contributor Author

Superseded by #959.

@dshemetov dshemetov deleted the ds/katie-test-refactor branch September 8, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue refactor Substantial projects to make the code do the same thing, better.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants