Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page refresh on vm disconnect #638

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Fix page refresh on vm disconnect #638

merged 3 commits into from
Feb 2, 2024

Conversation

sei-aschlackman
Copy link
Contributor

@sei-aschlackman sei-aschlackman commented Feb 2, 2024 •
edited
Loading

  • Attempt to recreate vm connection on disconnect, rather than reloading the entire page
  • Update to Angular 15 and latest Crucible.Common.Ui
    • BREAKING CHANGE - Update your settings.env.json so that the silent_redirect_uri points to the static auth-callback-silent.html, rather than the previous auth-callback-silent route . You may also need to update the allowed redirect_uri setting in your identity provider.

@sei-aschlackman
update to angular 15
1b6f39e
@sei-aschlackman
don't refresh page on vm disconnect
b86a629 
- attempt to recreate vm connection on disconnect, rather than reloading the entire page
- update to latest crucible.common.ui
@sei-aschlackman
dependency fix
13fddfd
@sei-aschlackman sei-aschlackman marked this pull request as ready for review February 2, 2024 16:22
@sei-aschlackman sei-aschlackman merged commit 6be409b into development Feb 2, 2024
3 checks passed
@sei-aschlackman sei-aschlackman deleted the connection-issues branch February 2, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sei-tspencer sei-tspencer Awaiting requested review from sei-tspencer sei-tspencer is a code owner

@sei-chershberger sei-chershberger Awaiting requested review from sei-chershberger sei-chershberger is a code owner

@sei-noconnor sei-noconnor Awaiting requested review from sei-noconnor sei-noconnor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sei-aschlackman