Add way for user to define the scopes used #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2024 13:47
Mackamuir
requested review from
sei-tspencer,
sei-chershberger,
sei-aschlackman and
sei-noconnor
as code owners
|
Hey @Mackamuir, thanks for the PR! I pushed a commit that should allow client_scopes to be optional. I tested it on my end, but can you confirm if you still see any issues with that? Otherwise, looks good. |
|
Works well on my end, success when I define scopes and 403 when I don't (as expected), cheers for the help. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue when using Authentik as my SSO provider using this module as Authentik won't automatically add scopes to a token unless they are requested, this pull request aims to fix that by allowing the user to define scopes to add to the token.
Had some issues with trying to handle if client_scopes is not defined so just left it as required.