Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QOL Fixes and Metrics Improvements #258

Merged
merged 33 commits into from
Jan 13, 2024
Merged

QOL Fixes and Metrics Improvements #258

merged 33 commits into from
Jan 13, 2024

Conversation

jacksontromero
Copy link
Collaborator

Big merge from preview into production. Below is a list of (I think) all major features/fixes

  • Fix student setting preferred name giving erroneous error
  • Show preferred name change in mobile
  • Write admin settings to a json file so they persist between server restarts
  • Fix existing broken metrics graphs (lots and lots of fixes here)
  • Limit metrics to the current semester
  • Add new admin-only metrics charts
  • Add admin option for enforcing CMU emails

a26blass and others added 30 commits December 23, 2023 19:35
@a26blass
Important admin settings (Semester, Slack Webhooks, Questions URL, Re…
373e4e7 
…join Time) are now saved to a file and loaded if the queue is restarted
@jacksontromero
add adminSettings.json to gitignore
d052ba7
@jacksontromero
fix queue rejoin field on settings page
cb0b546
@jacksontromero
Include locations in saved admin settings
4ebed9d
@jacksontromero
respond success works for TAs and Students
9d52bf5
@jacksontromero
Show change name button on mobile view
7aecdc1
@jacksontromero
Show change name before logout in mobile
c1bd90f
@jacksontromero
Add chart.js
5dab750
@jacksontromero
Make a bit larger
06eb4ef
@jacksontromero
Fix numStudentsPerDayLastWeek
5222f84
@jacksontromero
Small server-side potential fix for number of students per day last w…
620bbcd 
…eek, should check this fix on the live DB
@jacksontromero
Update metrics queries to work correctly and use charts.js instead of…
6c4b9c6 
… recharts
@jacksontromero
Sort by day of week
bd1be49
@jacksontromero
Use date objects and 8hr windows
8d5fff7
@jacksontromero
Merge pull request #253 from cmu15122/jtromero/metricsFixes
5cb1670 
Jtromero/metrics fixes
@jacksontromero
Account for EST time zone in metrics calculations
7db1879
@jacksontromero
prevent vertical growth on graphs when resizing page
f484612
@jacksontromero
Merge pull request #254 from cmu15122/jtromero/metricsFixes
35cb11a 
Jtromero/metrics fixes
@jacksontromero
Merge pull request #252 from cmu15122/jtromero/preferredNameFixes
b39f1d0 
Preferred Name Fixes
@jacksontromero
Change default semester to S23 because of legacy reasons lol
60a0ddf
@jacksontromero
Merge pull request #251 from cmu15122/alexb/persistentsettings
ae85617 
Store / load admin settings from a file
@jacksontromero
Add ranked students and TAs to metrics for admins
a767ed6
@jacksontromero
Account for current semester and only look at completed questions for…
85b71ba 
… metrics
@jacksontromero
Enforce semester on today's stats
7734453
@jacksontromero
Formatting and naming on metrics page
c300254
@jacksontromero
Add number of times asked to fix to student rank
c29ae2d
@jacksontromero
Remove console.log in metrics.js
335002a
@jacksontromero
clean up unused imports and other compilation warnings
c8919f2
@jacksontromero
Merge pull request #255 from cmu15122/jtromero/metricsPolish
529efc6 
Jtromero/metrics polish
@jacksontromero
Add option to enforce CMU email as an admin setting
8dd6d98
@jacksontromero jacksontromero merged commit de305fe into production Jan 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacksontromero @a26blass