Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unified strain design #519

Merged
merged 6 commits into from
Aug 16, 2024
Merged

unified strain design #519

merged 6 commits into from
Aug 16, 2024

Conversation

axelvonkamp
Copy link
Member

@axelvonkamp axelvonkamp commented Jul 4, 2024

optlang_enumerator is now an additional option in the strain design dialog

@axelvonkamp axelvonkamp changed the title update dependencies unified strain design Jul 4, 2024
@axelvonkamp axelvonkamp self-assigned this Jul 4, 2024
if self.solver_buttons['OPTLANG'].isChecked():
if len(bilvl_modules) > 0:
QMessageBox.information(self, "Bilevel modules not supported",
"Mmodule types 'OptKnock', " +\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module*

QMessageBox.information(self, "Bilevel modules not supported",
"Mmodule types 'OptKnock', " +\
"'RobustKnock' and 'OptCouple' are not supported " +\
"by optlang_enumerator.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In these optlang-specific error messages, it would be nice to direct the user to a different solver, e.g. "Please use a different solver such as GLPK to use these unsupported features.".

@Paulocracy
Copy link
Member

I get the following error when using e.g. "R1 >= 1.0" as suppressed module in the SmallExample model with optlang_enumerator:

Traceback (most recent call last): File "/scratch/GitHub/CNApy/cnapy/gui_elements/strain_design_dialog.py", line 1457, in compute_optlang mcs,
err_val = mcs_computation.compute_mcs(model, TypeError: compute_mcs() got an unexpected keyword argument 'knock_in_idx' 

@axelvonkamp
Copy link
Member Author

I get the following error when using e.g. "R1 >= 1.0" as suppressed module in the SmallExample model with optlang_enumerator:

Traceback (most recent call last): File "/scratch/GitHub/CNApy/cnapy/gui_elements/strain_design_dialog.py", line 1457, in compute_optlang mcs,
err_val = mcs_computation.compute_mcs(model, TypeError: compute_mcs() got an unexpected keyword argument 'knock_in_idx' 

You need to upgrade optlang_enumerator to 0.0.10

Copy link
Member

@VonAlphaBisZulu VonAlphaBisZulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the optlang function and checked flux space plotting. Both look great! But someone else should make the final call on this PR.

Copy link
Member

@Paulocracy Paulocracy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fantastic work :D

@Paulocracy Paulocracy merged commit 6281b80 into master Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants