-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unified strain design #519
Conversation
if self.solver_buttons['OPTLANG'].isChecked(): | ||
if len(bilvl_modules) > 0: | ||
QMessageBox.information(self, "Bilevel modules not supported", | ||
"Mmodule types 'OptKnock', " +\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module*
QMessageBox.information(self, "Bilevel modules not supported", | ||
"Mmodule types 'OptKnock', " +\ | ||
"'RobustKnock' and 'OptCouple' are not supported " +\ | ||
"by optlang_enumerator.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In these optlang-specific error messages, it would be nice to direct the user to a different solver, e.g. "Please use a different solver such as GLPK to use these unsupported features.".
I get the following error when using e.g. "R1 >= 1.0" as suppressed module in the SmallExample model with optlang_enumerator:
|
You need to upgrade optlang_enumerator to 0.0.10 |
better window management of strain design dialogs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the optlang function and checked flux space plotting. Both look great! But someone else should make the final call on this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fantastic work :D
optlang_enumerator is now an additional option in the strain design dialog