fix: ignore fix invalid version (#498)

cnpm · Jun 7, 2023 · f5607c0 · f5607c0
1 parent cb5117a
commit f5607c0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/app/core/entity/PaddingSemVer.ts b/app/core/entity/PaddingSemVer.ts
@@ -28,7 +28,7 @@ export class PaddingSemVer {
 
   // 版本信息中为纯数字, JS 中支持的最大整型为 16 位
   // 因此填充成 16 位对齐，如果版本号超过 16 位，则抛出异常
-  static paddingVersion(v) {
+  static paddingVersion(v: number) {
     const t = String(v);
     if (t.length <= 16) {
       const padding = new Array(16 - t.length).fill(0)

diff --git a/app/core/service/FixNoPaddingVersionService.ts b/app/core/service/FixNoPaddingVersionService.ts
@@ -1,6 +1,7 @@
 import { SingletonProto, AccessLevel, Inject } from '@eggjs/tegg';
 import { EggLogger } from 'egg';
 import pMap from 'p-map';
+import semver from 'semver';
 import { PackageVersionRepository } from '../../repository/PackageVersionRepository';
 import { PaddingSemVer } from '../entity/PaddingSemVer';
 
@@ -25,6 +26,8 @@ export class FixNoPaddingVersionService {
       this.logger.info('[FixNoPaddingVersionService] fix padding version ids %j', packageVersions.map(t => t.id));
 
       await pMap(packageVersions, async packageVersion => {
+        // ignore invalid version, e.g.: '1000000000000000000.0.0' on https://registry.npmjs.com/latentflip-test
+        if (!semver.valid(packageVersion.version)) return;
         const paddingSemver = new PaddingSemVer(packageVersion.version);
         await this.packageVersionRepository.fixPaddingVersion(packageVersion.packageVersionId, paddingSemver);
       }, { concurrency: 30 });

diff --git a/sql/3.28.0.sql b/sql/3.28.0.sql
@@ -3,6 +3,6 @@ ALTER TABLE
   ADD
     COLUMN padding_version varchar(255) DEFAULT NULL COMMENT 'token name',
   ADD
-    COLUMN `is_pre_release` tinyint(4) DEFAULT NULL COMMENT '是否是先行版本',
+    COLUMN `is_pre_release` tinyint(4) DEFAULT NULL COMMENT 'pre release version or not',
   ADD
     KEY `idx_pkg_id_is_pre_release_padding_version` (`package_id`, `padding_version`, `is_pre_release`, `version`);