Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node版本限制问题 #530

Closed
nxps opened this issue Jun 25, 2023 · 9 comments · Fixed by #531
Closed

node版本限制问题 #530

nxps opened this issue Jun 25, 2023 · 9 comments · Fixed by #531
Assignees
Labels
bug Something isn't working

Comments

@nxps
Copy link

nxps commented Jun 25, 2023

cnpmcore项目 node 版本限制是>= 16.13.0,但是 s3-cnpmcore 必须是 18,cnpmcore 的 node 版本限制是否应该升级一下?

@github-actions
Copy link

我们已经看到你的反馈,如果是功能缺陷,可以提供一下重现该问题的方式;如果是新功能需求,我们会尽快加入讨论。同时我们非常期待你可以加入我们的贡献者行列,让项目可以长期可持续发展。

@hezhengxu2018
Copy link
Collaborator

s3-cnpmcore是基于aws新版sdk的包装,用到了部分nodejs18的特性。通过配置CNPMCORE_NFS_TYPE可以使用别的nfsAdapter,s3v2-cnpmcore是基于旧sdk的封装,nodejs16也可以运行。当然这部分的配置需要自己添加,不能仅通过环境变量了。
可以修改成推荐nodejs >=18,最低要求依旧是nodejs>=16.13

@nxps
Copy link
Author

nxps commented Jun 25, 2023

使用 npm 或者 yarn 安装会报错,必须加上参数 --ignore-engines,既然 nodejs16也能运行,s3-cnpmcore 的 node版本限制能改一下吗

@fengmk2
Copy link
Member

fengmk2 commented Jun 25, 2023

@nxps 报错信息能否发一下,我加一个 optional deps 吧

@fengmk2
Copy link
Member

fengmk2 commented Jun 25, 2023

image
看起来只是一个 warning 日志提示?

@nxps
Copy link
Author

nxps commented Jun 25, 2023

[1/5] 🔍 Validating package.json...
[2/5] 🔍 Resolving packages...
[3/5] 🚚 Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version ">= 18.0.0". Got "16.20.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@nxps
Copy link
Author

nxps commented Jun 25, 2023

yarn 默认会强制检查

@fengmk2
Copy link
Member

fengmk2 commented Jun 25, 2023

哦,yarn 是直接报错,我改改
image

fengmk2 added a commit that referenced this issue Jun 25, 2023
@fengmk2 fengmk2 self-assigned this Jun 25, 2023
@fengmk2 fengmk2 added the bug Something isn't working label Jun 25, 2023
@fengmk2
Copy link
Member

fengmk2 commented Jun 25, 2023

@nxps 最新的代码分支修复了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants