fix: only auto install s3-cnpmcore on Node.js 18+ #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -111,6 +111,9 @@ | |||
| "ua-parser-js": "^1.0.34", | |||
| "validate-npm-package-name": "^3.0.0" | |||
| }, | |||
| "optionalDependencies": { | |||
| "s3-cnpmcore": "^1.1.2" | |||
| }, | |||
| "devDependencies": { | |||
| "@cnpmjs/npm-cli-login": "^1.1.0", | |||
| "@simplewebauthn/typescript-types": "^7.0.0", | |||
There was a problem hiding this comment.
这段代码是一个 package.json 文件的一个补丁。
- "optionalDependencies": {
- "s3-cnpmcore": "^1.1.2"
- },
以上部分添加了一个名为 s3-cnpmcore 的可选依赖项。如果已安装它，则 npm 还将自动安装此包，并且它不会在常规安装过程中强制安装。该更改意味着，可选安装包是软件的一部分，但是在某些情况下，可能不需要进行安装，从而减少了对运行环境的要求。
关于代码是否正确或存在漏洞风险，由于 code patch 中只展示了 package.json 文件的一部分，因此没有足够的上下文来做出充分评估和确定。
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 174 174
Lines 16546 16546
Branches 2163 2163
=======================================
Hits 16046 16046
Misses 500 500 |
fengmk2
pushed a commit
that referenced
this pull request
Jun 25, 2023
[skip ci] ## [3.34.6](v3.34.5...v3.34.6) (2023-06-25) ### Bug Fixes * only auto install s3-cnpmcore on Node.js 18+ ([#531](#531)) ([c9d9ce8](c9d9ce8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #530