Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Dockerfile and S3 nfs #509

Merged
merged 7 commits into from
Jun 12, 2023
Merged

feat: support Dockerfile and S3 nfs #509

merged 7 commits into from
Jun 12, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jun 11, 2023

closes #507

@fengmk2 fengmk2 added the enhancement New feature or request label Jun 11, 2023
@fengmk2 fengmk2 requested a review from elrrrrrrr June 11, 2023 09:31
@fengmk2 fengmk2 changed the title Minio feat: support Dockerfile and S3 nfs Jun 11, 2023
Dockerfile Show resolved Hide resolved
config/config.default.ts Outdated Show resolved Hide resolved
INTEGRATE.md Show resolved Hide resolved
@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
s3-cnpmcore 🆕 1.1.2 None +0 11.9 kB hezhengxu

Footnotes

  1. https://docs.socket.dev

package.json Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@fengmk2
Copy link
Member Author

fengmk2 commented Jun 11, 2023

https://registry-demo.fengmk2.com 可以玩了。

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Merging #509 (e485e6b) into master (a9bb81a) will decrease coverage by 0.11%.
The diff coverage is 22.72%.

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage   97.15%   97.05%   -0.11%     
==========================================
  Files         174      174              
  Lines       16368    16388      +20     
  Branches     2113     2114       +1     
==========================================
+ Hits        15903    15905       +2     
- Misses        465      483      +18     
Impacted Files Coverage Δ
config/config.default.ts 88.42% <22.72%> (-9.23%) ⬇️


## 演示地址

https://registry-demo.fengmk2.com
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elrrrrrrr #508 (comment) 我部署了一个 demo,是可以复现的。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elrrrrrrr #508 (comment) 我部署了一个 demo,是可以复现的。

(⊙o⊙)…是在群晖上部署的,默认的 443 端口会被运营商屏蔽 无法访问。

如果操作步骤是按文档用管理员账号登录,按现在的设计,预期是可以发任何包,包括不带 scope 的公网包。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你访问不了?
好吧,我后面加个配置项,管理员也不允许。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


```bash
docker pull fengmk2/cnpmcore
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此代码是一份Docker部署cnpmcore的脚本,它提供了构建cnpmcore镜像、设置环境变量参数、覆盖配置文件和运行容器等步骤。需要在docker容器内设置数据存储参数,并提供了MySQL、Redis和文件存储等选项。另外,还提供了使用config.prod.js覆盖默认prod配置文件、演示地址及fengmk2/cnpmcore docker 镜像的链接等其他信息。建议优化: 1.建议在文档中附加可用版本信息和所需资源。

@fengmk2 fengmk2 merged commit f61ef1c into master Jun 12, 2023
@fengmk2 fengmk2 deleted the minio branch June 12, 2023 01:19
fengmk2 pushed a commit that referenced this pull request Jun 12, 2023
[skip ci]

## [3.33.0](v3.32.0...v3.33.0) (2023-06-12)

### Features

* support Dockerfile and S3 nfs ([#509](#509)) ([f61ef1c](f61ef1c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile
2 participants