fix: sync self pkg #532
Merged
fix: sync self pkg #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elrrrrrrr
commented
Jun 25, 2023
elrrrrrrr
commented
- 🐞 When executing the syncTask, filter out scenarios where the target registry is the self registry.
- 🐞 syncTask 执行时，先过滤目标 registry 是当前 registry 的场景。
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| task.taskId, task.targetName); | ||
| return; | ||
| } | ||
|
|
||
| if (pkg && pkg?.registryId !== registry?.registryId) { | ||
| if (pkg.registryId) { | ||
| logs.push(`[${isoNow()}] ❌❌❌❌❌ ${fullname} registry is ${pkg.registryId} not belong to ${registry?.registryId}, skip sync ❌❌❌❌❌`); |
There was a problem hiding this comment.
这段代码的变更是将 SyncDeleteMode 移动到 constants.ts 中并添加了 PresetRegistryName 常量。
对于代码中的修改，似乎没有风险或错误。添加PreserRegistryName 可以使代码更加清晰且易于维护。
在行号为 372 处，如果 registry?.name 是 PresetRegistryName.self 则不需要执行同步操作，会记录一条日志并退出该方法。这样做使代码结构更清晰，也可以避免意外的同步错误。
| assert(log.includes(`${name} has been published to the self registry, skip sync ❌❌❌❌❌`)); | ||
|
|
||
| }); | ||
|
|
||
| it('should updated package manifests when version insert duplicated', async () => { | ||
| // https://www.npmjs.com/package/@cnpmcore/test-sync-package-has-two-versions | ||
| const name = '@cnpmcore/test-sync-package-has-two-versions'; |
There was a problem hiding this comment.
这段代码是针对 test/core/service/PackageSyncerService/executeTask.test.ts 中的一个测试用例。在添加一个新的测试用例，用于确保当同步任务是自注册表时，跳过同步。在测试之前，该用例创建了一个名为 @cnpmcore/test-self-sync 的包，并将它发布到自注册表中进行测试。测试执行后，通过读取任务日志来验证是否成功地跳过了同步任务，并输出消息“已将＊＊＊发布到自注册表中，跳过同步”。建议对日志编写更加详细的测试用例，以方便调试和验证。
Codecov Report
@@ Coverage Diff @@
## master #532 +/- ##
==========================================
- Coverage 97.03% 96.97% -0.06%
==========================================
Files 174 174
Lines 16546 16554 +8
Branches 2168 2165 -3
==========================================
- Hits 16055 16054 -1
- Misses 491 500 +9
|
fengmk2
approved these changes
Jun 25, 2023
fengmk2
pushed a commit
that referenced
this pull request
Jun 25, 2023
[skip ci] ## [3.34.7](v3.34.6...v3.34.7) (2023-06-25) ### Bug Fixes * sync self pkg ([#532](#532)) ([ada3e22](ada3e22))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.