feat: add lastUsedAt for classic token #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -113,7 +113,7 @@ export class UserRoleManager { | |||
| } | |||
|
|
|||
| // check token expired & set lastUsedAt | |||
| await this.tokenService.checkTokenExpired(authorizedUserAndToken.token); | |||
| await this.tokenService.checkTokenStatus(authorizedUserAndToken.token); | |||
| this.currentAuthorizedToken = authorizedUserAndToken.token; | |||
| this.currentAuthorizedUser = authorizedUserAndToken.user; | |||
| ctx.userId = authorizedUserAndToken.user.userId; | |||
There was a problem hiding this comment.
这段代码是一个UserRoleManager类中的一部分。代码检查了令牌是否过期，并设置了lastUsedAt的值。
在修改的代码行中，将调用checkTokenExpired方法改为了checkTokenStatus方法。
对于代码的风险和改进建议，我目前无法提供详细信息，因为我无法看到完整的代码上下文和相关代码。但是，根据给出的部分代码，没有明显的错误或问题，而且修改似乎只是用不同的方法名替换了原有的方法名。
如果您提供更多的上下文或代码细节，我可能能够给出更具体的反馈。
| const lastUsedAt = res.body.objects[0].lastUsedAt; | ||
| assert(dayjs(lastUsedAt).isAfter(now)); | ||
| }); | ||
|
|
||
| it('should 401 when readonly token access', async () => { | ||
| const { authorization } = await TestUtil.createUser({ tokenOptions: { readonly: true } }); | ||
| const res = await app.httpRequest() |
There was a problem hiding this comment.
这段代码看起来是一个关于TokenController的测试。
潜在的问题和改进建议如下：
- 引入
dayjs库之后没有执行npm install命令，可能会导致缺少依赖。需要确保安装了dayjs库。 - 在第二个测试用例中，通过调用
TestUtil.createUser()创建用户并获取authorization。然而，在之后没有清理创建的用户或回滚对数据库的更改。建议在测试运行结束后进行清理操作，以确保数据库的一致性。 - 第二个测试用例验证了
lastUsedAt属性是否在当前时间之后，但是使用了Date.now()来获取当前时间。为了准确比较时间，建议使用dayjs库提供的方法来获取当前时间，例如dayjs().valueOf()。
总体上看，代码比较简洁，没有明显的错误。以上是一些建议和潜在问题，供参考。
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
- Coverage 97.02% 96.96% -0.06%
==========================================
Files 174 174
Lines 16632 16627 -5
Branches 2186 2180 -6
==========================================
- Hits 16137 16123 -14
- Misses 495 504 +9
|
fengmk2
pushed a commit
that referenced
this pull request
Jul 12, 2023
[skip ci] ## [3.37.0](v3.36.0...v3.37.0) (2023-07-12) ### Features * add lastUsedAt for classic token ([#547](#547)) ([e061685](e061685))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkTokenExpiredmethod tocheckTokenStatuswhich update the token field internally.checkTokenExpired方法为checkTokenStatus，内部进行 token 字段更新