fix: playwright config #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elrrrrrrr
commented
Jul 13, 2023
elrrrrrrr
commented
- 🧶 Update Playwright configuration information.
- 🧶 更新 playwright 配置信息
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
=======================================
Coverage 96.96% 96.97%
=======================================
Files 174 174
Lines 16627 16641 +14
Branches 2179 2179
=======================================
+ Hits 16123 16137 +14
Misses 504 504
|
|
commit 是空的？ |
elrrrrrrr
force-pushed
the
fix-playwright-config
branch
from
82fe812
to
6d0afa3
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| '<unknown>': 'builds/android/%s/android.zip', | ||
| }, | ||
| '<unknown>': 'builds/android/%s/android.zip' | ||
| } | ||
| }; | ||
|
|
||
| @SingletonProto() |
There was a problem hiding this comment.
这段代码是一个常量对象的补丁，用于更新下载路径。以下是一些bug风险和改进建议：
-
DOWNLOAD_PATHS对象中增加了关于debian12和debian12-arm64的下载路径。确保这些路径指向正确的文件并存在相应的构建。 -
对于
'debian12'和'debian12-arm64'的下载路径，给定值为undefined。确保这不会导致后续代码中的错误或异常。 -
检查所有其他的更改，特别注意是否涉及到系统版本号或特定操作系统的路径。确保这些路径与要支持的系统版本和操作系统对应。
这些是关于代码补丁的简要审查。请确保在实际应用中进行彻底测试以验证这些更改。
elrrrrrrr
force-pushed
the
fix-playwright-config
branch
from
6d0afa3
to
c355895
Compare
| @@ -161,6 +173,8 @@ const DOWNLOAD_PATHS = { | |||
| 'ubuntu22.04-arm64': 'builds/ffmpeg/%s/ffmpeg-linux-arm64.zip', | |||
| 'debian11': 'builds/ffmpeg/%s/ffmpeg-linux.zip', | |||
| 'debian11-arm64': 'builds/ffmpeg/%s/ffmpeg-linux-arm64.zip', | |||
| 'debian12': 'builds/ffmpeg/%s/ffmpeg-linux.zip', | |||
| 'debian12-arm64': 'builds/ffmpeg/%s/ffmpeg-linux-arm64.zip', | |||
| 'mac10.13': 'builds/ffmpeg/%s/ffmpeg-mac.zip', | |||
| 'mac10.14': 'builds/ffmpeg/%s/ffmpeg-mac.zip', | |||
| 'mac10.15': 'builds/ffmpeg/%s/ffmpeg-mac.zip', | |||
There was a problem hiding this comment.
这段代码补丁涉及修改了下载路径的常量定义。主要改动如下：
- 增加了适用于 Debian 12 和 Debian 12 ARM64 的下载路径。
- 在 'firefox' 和 'firefox-beta' 下载路径中，删除了适用于 'debian12' 和 'debian12-arm64' 的定义，并将适用于 MacOS 版本 11、12 和 13 的下载路径指向了对应的版本号为 13 的文件。
- 在 'webkit' 下载路径中，删除了适用于 'debian12' 和 'debian12-arm64' 的定义，并将适用于 MacOS 版本 10.13 的下载路径设为 undefined。
- 在 'ffmpeg' 下载路径中，增加了适用于 Debian 12 和 Debian 12 ARM64 的下载路径。
所以针对该代码补丁的风险和改进建议如下：
- 风险：可能存在未定义部分的下载路径，如 'debian12' 和 'debian12-arm64' 在 'firefox' 和 'firefox-beta' 中。
- 改进建议：需要确认并提供适用于 'debian12' 和 'debian12-arm64' 的下载路径，以避免潜在的错误和问题。
|
LGTM |
fengmk2
pushed a commit
that referenced
this pull request
Jul 13, 2023
[skip ci] ## [3.37.1](v3.37.0...v3.37.1) (2023-07-13) ### Bug Fixes * playwright bianry sync config ([#548](#548)) ([166e334](166e334))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.