fix: don't log NotImplementedError to error log #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fengmk2
commented
Aug 1, 2023
fengmk2
commented
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
==========================================
- Coverage 97.03% 96.98% -0.06%
==========================================
Files 175 175
Lines 16713 16714 +1
Branches 2200 2196 -4
==========================================
- Hits 16218 16210 -8
- Misses 495 504 +9
|
fengmk2
pushed a commit
that referenced
this pull request
Aug 1, 2023
[skip ci] ## [3.39.3](v3.39.2...v3.39.3) (2023-08-01) ### Bug Fixes * don't log NotImplementedError to error log ([#563](#563)) ([bcf3547](bcf3547))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.