-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: publisher info #565
Merged
fix: publisher info #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elrrrrrrr
commented
Aug 4, 2023
•
edited
Loading
edited
- 🧶 Fixed _npmUser field setting issue during initial sync, should use displayName.
- 🧶 skip diff abbreviated meta for _npmUser
- 🤖 Refined some TypeScript definitions, use isEqual to diff metas
- 🧶 修复 publisher 匹配,获取逻辑,应当用 displayName 进行匹配
- 🧶 精简 meta 信息,跳过比较不存在的 _npmUser 字段
- 🤖 调整部分 ts 定义,使用 isEqual 来进行 diff 比较
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
=======================================
Coverage 96.98% 96.98%
=======================================
Files 175 175
Lines 16714 16715 +1
Branches 2196 2196
=======================================
+ Hits 16210 16211 +1
Misses 504 504
|
gemwuu
reviewed
Aug 4, 2023
fengmk2
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
fengmk2
pushed a commit
that referenced
this pull request
Aug 4, 2023
[skip ci] ## [3.39.4](v3.39.3...v3.39.4) (2023-08-04) ### Bug Fixes * publisher info ([#565](#565)) ([94bcc1a](94bcc1a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.