Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publisher info #565

Merged
merged 3 commits into from
Aug 4, 2023
Merged

fix: publisher info #565

merged 3 commits into from
Aug 4, 2023

Conversation

elrrrrrrr
Copy link
Member

@elrrrrrrr elrrrrrrr commented Aug 4, 2023

Fixed an issue with the _npmUser field setting during the initial sync.

  1. 🧶 Fixed _npmUser field setting issue during initial sync, should use displayName.
  2. 🧶 skip diff abbreviated meta for _npmUser
  3. 🤖 Refined some TypeScript definitions, use isEqual to diff metas

修复首次同步时,_npmUser 字段设置异常

  1. 🧶 修复 publisher 匹配,获取逻辑,应当用 displayName 进行匹配
  2. 🧶 精简 meta 信息,跳过比较不存在的 _npmUser 字段
  3. 🤖 调整部分 ts 定义,使用 isEqual 来进行 diff 比较

@elrrrrrrr elrrrrrrr added the bug Something isn't working label Aug 4, 2023
@elrrrrrrr elrrrrrrr marked this pull request as draft August 4, 2023 04:01
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #565 (3b70d86) into master (bcf3547) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files         175      175           
  Lines       16714    16715    +1     
  Branches     2196     2196           
=======================================
+ Hits        16210    16211    +1     
  Misses        504      504           
Files Changed Coverage Δ
app/core/service/PackageManagerService.ts 98.86% <100.00%> (ø)
app/core/service/PackageSyncerService.ts 98.21% <100.00%> (-0.01%) ⬇️
app/repository/PackageRepository.ts 98.19% <100.00%> (+0.01%) ⬆️

@elrrrrrrr elrrrrrrr marked this pull request as ready for review August 4, 2023 05:27
Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fengmk2 fengmk2 merged commit 94bcc1a into master Aug 4, 2023
12 checks passed
@fengmk2 fengmk2 deleted the publisher branch August 4, 2023 05:45
fengmk2 pushed a commit that referenced this pull request Aug 4, 2023
[skip ci]

## [3.39.4](v3.39.3...v3.39.4) (2023-08-04)

### Bug Fixes

* publisher info ([#565](#565)) ([94bcc1a](94bcc1a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants